Issue 11887023: NaCl: Stop using "--enable-logging" because it breaks Buildbot logging on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11887023: NaCl: Stop using "--enable-logging" because it breaks Buildbot logging on Windows (Closed)

Created:
7 years, 11 months ago by Mark Seaborn

Modified:
7 years, 11 months ago

Reviewers:
Nick Bray (chromium)

CC:
chromium-reviews, pam+watch_chromium.org, bradn

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Stop using "--enable-logging" because it breaks Buildbot logging on Windows We used to get log output from the browser process in the Windows Buildbot logs in nacl_integration, such as: [...:ERROR:nacl_process_host.cc(210)] NaCl process exited with status -1073741819 (0xc0000005) but since the RouteStdioToConsole() call was added to Chrome, "--enable-logging" prevents that from being routed to the Buildbot logs. BUG=169941 TEST=check nacl_integration log output on Windows Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176772

Patch Set 1 #

Patch Set 2 : Add comment #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Brilliant. :/

Expand Messages | Collapse Messages