ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py - Issue 11887023: NaCl: Stop using "--enable-logging" because it breaks Buildbot logging on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py

Issue 11887023: NaCl: Stop using "--enable-logging" because it breaks Buildbot logging on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add comment Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py

diff --git a/ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py b/ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py

index f14c82e9d17a1041ea867cea41e09c85355d9776..d8bf9acf42fb48276186b25193c1349b5eb5de8d 100755

--- a/ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py

+++ b/ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py

@@ -266,11 +266,13 @@ class ChromeLauncher(BrowserLauncher):

def MakeCmd(self, url, port):

cmd = [self.binary,

+ # Note that we do not use "--enable-logging" here because

+ # it actually turns off logging to the Buildbot logs on

+ # Windows (see http://crbug.com/169941).

'--disable-web-resources',

'--disable-preconnect',

'--no-first-run',

'--no-default-browser-check',

- '--enable-logging',

'--log-level=1',

'--safebrowsing-disable-auto-update',

# Suppress metrics reporting. This prevents misconfigured bots,

« no previous file with comments | « no previous file | no next file » | no next file with comments »