Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: tools/dom/scripts/systemhtml.py

Issue 11887006: Changed @domName annotation in comment to full fledge @DomName annotation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Merged and stuff.' Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/systemhtml.py
diff --git a/tools/dom/scripts/systemhtml.py b/tools/dom/scripts/systemhtml.py
index c4f8f13abd0ee420aaac6226f163d8a589eef021..dc05a547a486f9e3dae9b3c47684392d121ae991 100644
--- a/tools/dom/scripts/systemhtml.py
+++ b/tools/dom/scripts/systemhtml.py
@@ -917,16 +917,17 @@ class Dart2JSBackend(HtmlDartGenerator):
return ''
def _Annotations(self, idl_type, idl_member_name):
+ out = ''
annotations = FindDart2JSAnnotations(idl_type, self._interface.id,
idl_member_name)
if annotations:
- return '%s\n ' % annotations
- return_type = self.SecureOutputType(idl_type)
- native_type = self._NarrowToImplementationType(idl_type)
- if native_type != return_type:
- return "@Returns('%s') @Creates('%s')\n " % (native_type, native_type)
- else:
- return ''
+ out += '%s\n ' % annotations
blois 2013/01/12 01:21:29 out =
Andrei Mouravski 2013/01/14 22:56:46 Done.
+ if not AnySpecificAnnotations(idl_type, self._interface.id, idl_member_name):
blois 2013/01/12 01:21:29 line length
blois 2013/01/12 01:21:29 Probably rename this to AnyConversionAnnotations a
Andrei Mouravski 2013/01/14 22:56:46 Done.
Andrei Mouravski 2013/01/14 22:56:46 Done.
blois 2013/01/15 22:26:32 Undone?
+ return_type = self.SecureOutputType(idl_type)
+ native_type = self._NarrowToImplementationType(idl_type)
+ if native_type != return_type:
+ out += "@Returns('%s') @Creates('%s')\n " % (native_type, native_type)
+ return out
def CustomJSMembers(self):
return _js_custom_members

Powered by Google App Engine
This is Rietveld 408576698