Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 11887006: Changed @domName annotation in comment to full fledge @DomName annotation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Merged and stuff.' Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/htmldartgenerator.py
diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py
index 26bda0c719bcc1d5d916c0737d54016d29d6952a..49a6fcd5da5d8dfc4129b6d2027bd2e12352d813 100644
--- a/tools/dom/scripts/htmldartgenerator.py
+++ b/tools/dom/scripts/htmldartgenerator.py
@@ -41,24 +41,22 @@ class HtmlDartGenerator(object):
""" Emits the MDN dartdoc comment for an attribute.
"""
dom_name = DartDomNameOfAttribute(attribute)
- self._members_emitter.Emit('\n /// @domName $DOMINTERFACE.$DOMNAME;'
- ' @docsEditable true',
+ self._members_emitter.Emit('\n /// @docsEditable true',
DOMINTERFACE=attribute.doc_js_interface_name,
DOMNAME=dom_name)
def EmitOperationDocumentation(self, operation):
""" Emits the MDN dartdoc comment for an operation.
"""
- self._members_emitter.Emit('\n /// @domName $DOMINTERFACE.$DOMNAME;'
- ' @docsEditable true',
+ self._members_emitter.Emit('\n /// @docsEditable true',
DOMINTERFACE=operation.overloads[0].doc_js_interface_name,
DOMNAME=operation.name)
def EmitEventGetter(self, events_class_name):
self._members_emitter.Emit(
- '\n /// @domName EventTarget.addEventListener, '
- 'EventTarget.removeEventListener, EventTarget.dispatchEvent;'
- ' @docsEditable true'
+ '\n /// @docsEditable true'
+ '\n @DomName("EventTarget.addEventListener, '
+ 'EventTarget.removeEventListener, EventTarget.dispatchEvent")'
'\n $TYPE get on =>\n new $TYPE(this);\n',
TYPE=events_class_name)
@@ -293,7 +291,7 @@ class HtmlDartGenerator(object):
def _AddConstructor(self,
constructor_info, factory_name, factory_constructor_name):
- self._members_emitter.Emit('\n ///@docsEditable true');
+ self._members_emitter.Emit('\n /// @docsEditable true');
if not factory_constructor_name:
factory_constructor_name = '_create'

Powered by Google App Engine
This is Rietveld 408576698