Changed @domName annotation in comment to full fledge @DomName annotation.

Changed @domName annotation in comment to full fledge @DomName annotation.

Committed: https://code.google.com/p/dart/source/detail?r=17154

[Andrei Mouravski, 2013-01-12 00:47:33]

Bam!

[blois, 2013-01-12 01:21:29]

https://codereview.chromium.org/11887006/diff/11048/sdk/lib/html/html_common/...
File sdk/lib/html/html_common/metadata.dart (right):

https://codereview.chromium.org/11887006/diff/11048/sdk/lib/html/html_common/...
sdk/lib/html/html_common/metadata.dart:5: library metadata;
Any specific reasons for this? I'd recommend breaking out into a separate CL, as
it's not unimaginable that problems are lurking.

https://codereview.chromium.org/11887006/diff/11048/sdk/lib/html/html_common/...
sdk/lib/html/html_common/metadata.dart:45: /// Metadata that specifies the DOM
name associated with the element.
Would add something to the extent that this is intended for API generation and
the format of name (class.member).

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/generat...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/generat...
tools/dom/scripts/generator.py:726: annotations.append('@DomName("' + key +
'")')
how about annotations = ['@DomName("' + key + '")']

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/systemh...
File tools/dom/scripts/systemhtml.py (right):

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/systemh...
tools/dom/scripts/systemhtml.py:924: out += '%s\n  ' % annotations
out =

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/systemh...
tools/dom/scripts/systemhtml.py:925: if not AnySpecificAnnotations(idl_type,
self._interface.id, idl_member_name):
line length

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/systemh...
tools/dom/scripts/systemhtml.py:925: if not AnySpecificAnnotations(idl_type,
self._interface.id, idl_member_name):
Probably rename this to AnyConversionAnnotations and only check dart2js
annotations.

https://codereview.chromium.org/11887006/diff/11048/tools/dom/templates/html/...
File tools/dom/templates/html/impl/pure_interface.darttemplate (right):

https://codereview.chromium.org/11887006/diff/11048/tools/dom/templates/html/...
tools/dom/templates/html/impl/pure_interface.darttemplate:7:
@DomName("$DOMNAME")
This one should probably have docseditable.

[Andrei Mouravski, 2013-01-14 22:56:46]

PTAL.

https://codereview.chromium.org/11887006/diff/11048/sdk/lib/html/html_common/...
File sdk/lib/html/html_common/metadata.dart (right):

https://codereview.chromium.org/11887006/diff/11048/sdk/lib/html/html_common/...
sdk/lib/html/html_common/metadata.dart:5: library metadata;
On 2013/01/12 01:21:29, blois wrote:
> Any specific reasons for this? I'd recommend breaking out into a separate CL,
as
> it's not unimaginable that problems are lurking.

Done.

https://codereview.chromium.org/11887006/diff/11048/sdk/lib/html/html_common/...
sdk/lib/html/html_common/metadata.dart:45: /// Metadata that specifies the DOM
name associated with the element.
On 2013/01/12 01:21:29, blois wrote:
> Would add something to the extent that this is intended for API generation and
> the format of name (class.member).

Done.

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/generat...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/generat...
tools/dom/scripts/generator.py:726: annotations.append('@DomName("' + key +
'")')
On 2013/01/12 01:21:29, blois wrote:
> how about annotations = ['@DomName("' + key + '")']

Done.

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/systemh...
File tools/dom/scripts/systemhtml.py (right):

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/systemh...
tools/dom/scripts/systemhtml.py:924: out += '%s\n  ' % annotations
On 2013/01/12 01:21:29, blois wrote:
> out = 

Done.

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/systemh...
tools/dom/scripts/systemhtml.py:925: if not AnySpecificAnnotations(idl_type,
self._interface.id, idl_member_name):
On 2013/01/12 01:21:29, blois wrote:
> line length

Done.

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/systemh...
tools/dom/scripts/systemhtml.py:925: if not AnySpecificAnnotations(idl_type,
self._interface.id, idl_member_name):
On 2013/01/12 01:21:29, blois wrote:
> Probably rename this to AnyConversionAnnotations and only check dart2js
> annotations.

Done.

https://codereview.chromium.org/11887006/diff/11048/tools/dom/templates/html/...
File tools/dom/templates/html/impl/pure_interface.darttemplate (right):

https://codereview.chromium.org/11887006/diff/11048/tools/dom/templates/html/...
tools/dom/templates/html/impl/pure_interface.darttemplate:7:
@DomName("$DOMNAME")
On 2013/01/12 01:21:29, blois wrote:
> This one should probably have docseditable.

Done.

[sra1, 2013-01-15 11:47:13]

lgtm.

Personally, I would have used single quotes for the generated strings.

https://codereview.chromium.org/11887006/diff/2050/sdk/lib/html/html_common/m...
File sdk/lib/html/html_common/metadata.dart (right):

https://codereview.chromium.org/11887006/diff/2050/sdk/lib/html/html_common/m...
sdk/lib/html/html_common/metadata.dart:53: final name;
Any reason this is not:
final String name;

[Andrei Mouravski, 2013-01-15 20:02:40]

PTAL.

[blois, 2013-01-15 22:26:32]

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/generat...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/generat...
tools/dom/scripts/generator.py:726: annotations.append('@DomName("' + key +
'")')
On 2013/01/14 22:56:46, Andrei Mouravski wrote:
> On 2013/01/12 01:21:29, blois wrote:
> > how about annotations = ['@DomName("' + key + '")']
> 
> Done.

Undone?

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/systemh...
File tools/dom/scripts/systemhtml.py (right):

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/systemh...
tools/dom/scripts/systemhtml.py:925: if not AnySpecificAnnotations(idl_type,
self._interface.id, idl_member_name):
On 2013/01/14 22:56:46, Andrei Mouravski wrote:
> On 2013/01/12 01:21:29, blois wrote:
> > Probably rename this to AnyConversionAnnotations and only check dart2js
> > annotations.
> 
> Done.

Undone?

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate
(right):

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate:7:
@DomName('$DOMNAME')
How about just $ANNOTATIONS for this and the others?

Might be able to remove DOMNAME from the template to enforce the new method of
doing it.

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate (right):

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate:6: ///
@docsEditable true
Not docsEditable

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_Navigator.darttemplate (right):

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_Navigator.darttemplate:7: ///
@docsEditable true
Not docsEditable.

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
File tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate (right):

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate:7:
@DomName('KeyboardEvent')
Not editable.

[Andrei Mouravski, 2013-01-16 00:24:25]

PTAL.

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/generat...
File tools/dom/scripts/generator.py (right):

https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/generat...
tools/dom/scripts/generator.py:726: annotations.append('@DomName("' + key +
'")')
On 2013/01/15 22:26:32, blois wrote:
> On 2013/01/14 22:56:46, Andrei Mouravski wrote:
> > On 2013/01/12 01:21:29, blois wrote:
> > > how about annotations = ['@DomName("' + key + '")']
> > 
> > Done.
> 
> Undone?

I'm confused. What's wrong here?

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate
(right):

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate:7:
@DomName('$DOMNAME')
On 2013/01/15 22:26:32, blois wrote:
> How about just $ANNOTATIONS for this and the others?
> 
> Might be able to remove DOMNAME from the template to enforce the new method of
> doing it.

Done.

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate (right):

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate:6: ///
@docsEditable true
On 2013/01/15 22:26:32, blois wrote:
> Not docsEditable

Done.

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/impl_Navigator.darttemplate (right):

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/impl_Navigator.darttemplate:7: ///
@docsEditable true
On 2013/01/15 22:26:32, blois wrote:
> Not docsEditable.

Done.

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
File tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate (right):

https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate:7:
@DomName('KeyboardEvent')
On 2013/01/15 22:26:32, blois wrote:
> Not editable.

Done.

[blois, 2013-01-16 01:49:39]

On 2013/01/16 00:24:25, Andrei Mouravski wrote:
> PTAL.
> 
>
https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/generat...
> File tools/dom/scripts/generator.py (right):
> 
>
https://codereview.chromium.org/11887006/diff/11048/tools/dom/scripts/generat...
> tools/dom/scripts/generator.py:726: annotations.append('@DomName("' + key +
> '")')
> On 2013/01/15 22:26:32, blois wrote:
> > On 2013/01/14 22:56:46, Andrei Mouravski wrote:
> > > On 2013/01/12 01:21:29, blois wrote:
> > > > how about annotations = ['@DomName("' + key + '")']
> > > 
> > > Done.
> > 
> > Undone?
> 
> I'm confused. What's wrong here?
Odd- for some reason I was seeing an older diff or something. Looks correct now.
> 
>
https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
> File tools/dom/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate
> (right):
> 
>
https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
> tools/dom/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate:7:
> @DomName('$DOMNAME')
> On 2013/01/15 22:26:32, blois wrote:
> > How about just $ANNOTATIONS for this and the others?
> > 
> > Might be able to remove DOMNAME from the template to enforce the new method
of
> > doing it.
> 
> Done.
> 
>
https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
> File tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate (right):
> 
>
https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
> tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate:6: ///
> @docsEditable true
> On 2013/01/15 22:26:32, blois wrote:
> > Not docsEditable
> 
> Done.
> 
>
https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
> File tools/dom/templates/html/dart2js/impl_Navigator.darttemplate (right):
> 
>
https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
> tools/dom/templates/html/dart2js/impl_Navigator.darttemplate:7: ///
> @docsEditable true
> On 2013/01/15 22:26:32, blois wrote:
> > Not docsEditable.
> 
> Done.
> 
>
https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
> File tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate (right):
> 
>
https://codereview.chromium.org/11887006/diff/9055/tools/dom/templates/html/d...
> tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate:7:
> @DomName('KeyboardEvent')
> On 2013/01/15 22:26:32, blois wrote:
> > Not editable.
> 
> Done.

[blois, 2013-01-16 01:49:52]

lgtm

[sra1, 2013-01-16 08:38:28]

lgtm