Changed @domName annotation in comment to full fledge @DomName annotation.

tools/dom/scripts/generator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for systems to generate
 Dart APIs from the IDL database."""
 
 import copy
 import re
@@ skipping 699 matching lines @@
     "@SupportedBrowser(SupportedBrowser.CHROME, '25')",
     "@Experimental()",
   ],
   'WebSocket': _all_but_ie9_annotations,
   'WorkerContext.indexedDB': _indexed_db_annotations,
 }
 
 def FindCommonAnnotations(interface_name, member_name=None):
   """ Finds annotations common between dart2js and dartium.
   """
+  annotations = []
   if member_name:
-    return dart_annotations.get('%s.%s' % (interface_name, member_name))
+    key = '%s.%s' % (interface_name, member_name)
   else:
-    return dart_annotations.get(interface_name)
+    key = interface_name
+
+  annotations.append('@DomName("' + key + '")')

[blois, 2013/01/12 01:21:29]

how about annotations = ['@DomName("' + key + '")']

[Andrei Mouravski, 2013/01/14 22:56:46]

Done.

[blois, 2013/01/15 22:26:32]

Undone?

[Andrei Mouravski, 2013/01/16 00:24:25]

I'm confused. What's wrong here?

+  if (dart_annotations.get(key) != None):
+    annotations.extend(dart_annotations.get(key))
+
+  return annotations
 
 def FindDart2JSAnnotations(idl_type, interface_name, member_name):
   """ Finds all annotations for Dart2JS members- including annotations for
   both dart2js and dartium.
   """
   annotations = FindCommonAnnotations(interface_name, member_name)
   if annotations:
     annotations = ' '.join(annotations)
 
   ann2 = _FindDart2JSSpecificAnnotations(idl_type, interface_name, member_name)
   if ann2:
     if annotations:
       annotations = annotations + ' ' + ann2
     else:
       annotations = ann2
   return annotations
 
+def AnySpecificAnnotations(idl_type, interface_name, member_name):
+  if (dart_annotations.get('%s.%s' % (interface_name, member_name)) or
+      _FindDart2JSSpecificAnnotations(idl_type, interface_name, member_name)):
+    return True
+  else:
+    return False
+
 def _FindDart2JSSpecificAnnotations(idl_type, interface_name, member_name):
   """ Finds dart2js-specific annotations. This does not include ones shared with
   dartium.
   """
   ann1 = dart2js_annotations.get("%s.%s" % (interface_name, member_name))
   if ann1:
     ann2 = dart2js_annotations.get('+' + idl_type)
     if ann2:
       return ann2 + ' ' + ann1
     ann2 = dart2js_annotations.get(idl_type)
@@ skipping 533 matching lines @@
                                   self)
 
     if type_data.clazz == 'SVGTearOff':
       dart_interface_name = self._renamer.RenameInterface(
           self._database.GetInterface(type_name))
       return SVGTearOffIDLTypeInfo(
           type_name, type_data, dart_interface_name, self)
 
     class_name = '%sIDLTypeInfo' % type_data.clazz
     return globals()[class_name](type_name, type_data)