Issue 11886079: Revert 177136 due to memory error on Mac ASAN

Issue 11886079: Revert 177136 due to memory error on Mac ASAN (Closed)

Created:
7 years, 11 months ago by Charlie Reis

Modified:
7 years, 11 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 177136 > Move auth-error reporting code out of SyncGlobalError and into SigninGlobalError > > This is the first step towards enabling signin even when sync is disabled by > policy. > > BUG=166148, 113133 > > > Review URL: https://chromiumcodereview.appspot.com/11817045 TBR=atwilson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177206

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+222 lines, -672 lines)			Patch
M	chrome/app/chrome_command_ids.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/defaults.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/defaults.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/signin/oauth2_token_service.h	View	5 chunks	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/signin/oauth2_token_service.cc	View	6 chunks	+1 line, -41 lines	0 comments	Download
M	chrome/browser/signin/oauth2_token_service_factory.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/browser/signin/signin_global_error.h	View	1 chunk	+0 lines, -73 lines	0 comments	Download
D	chrome/browser/signin/signin_global_error.cc	View	1 chunk	+0 lines, -202 lines	0 comments	Download
D	chrome/browser/signin/signin_global_error_unittest.cc	View	1 chunk	+0 lines, -155 lines	0 comments	Download
MM	chrome/browser/signin/signin_manager.h	View	3 chunks	+1 line, -14 lines	0 comments	Download
M	chrome/browser/signin/signin_manager.cc	View	3 chunks	+1 line, -18 lines	0 comments	Download
M	chrome/browser/signin/signin_manager_factory.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
MM	chrome/browser/signin/signin_manager_fake.cc	View	1 chunk	+1 line, -13 lines	0 comments	Download
M	chrome/browser/signin/signin_manager_unittest.cc	View	6 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	5 chunks	+1 line, -14 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_global_error.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/sync_global_error.cc	View	4 chunks	+15 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_global_error_unittest.cc	View	2 chunks	+46 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_ui_util.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util.cc	View	9 chunks	+86 lines, -6 lines	0 comments	Download
MM	chrome/browser/sync/sync_ui_util_unittest.cc	View	3 chunks	+26 lines, -21 lines	0 comments	Download
M	chrome/browser/ui/toolbar/wrench_menu_model.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/ui/toolbar/wrench_menu_model.cc	View	9 chunks	+30 lines, -59 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages