Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7207)

Unified Diff: chrome/browser/signin/oauth2_token_service.cc

Issue 11886079: Revert 177136 due to memory error on Mac ASAN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/oauth2_token_service.h ('k') | chrome/browser/signin/oauth2_token_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/oauth2_token_service.cc
===================================================================
--- chrome/browser/signin/oauth2_token_service.cc (revision 177205)
+++ chrome/browser/signin/oauth2_token_service.cc (working copy)
@@ -15,8 +15,6 @@
#include "base/timer.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/signin/oauth2_token_service_factory.h"
-#include "chrome/browser/signin/signin_manager.h"
-#include "chrome/browser/signin/signin_manager_factory.h"
#include "chrome/browser/signin/token_service.h"
#include "chrome/browser/signin/token_service_factory.h"
#include "chrome/common/chrome_notification_types.h"
@@ -131,9 +129,6 @@
const OAuth2TokenService::ScopeSet& GetScopeSet() const;
const std::string& GetRefreshToken() const;
- // The error result from this fetcher.
- const GoogleServiceAuthError& error() const { return error_; }
-
protected:
// OAuth2AccessTokenConsumer
virtual void OnGetTokenSuccess(const std::string& access_token,
@@ -321,9 +316,7 @@
OAuth2TokenService::Consumer::~Consumer() {
}
-OAuth2TokenService::OAuth2TokenService()
- : profile_(NULL),
- last_auth_error_(GoogleServiceAuthError::NONE) {
+OAuth2TokenService::OAuth2TokenService() : profile_(NULL) {
}
OAuth2TokenService::~OAuth2TokenService() {
@@ -347,18 +340,8 @@
registrar_.Add(this,
chrome::NOTIFICATION_TOKEN_AVAILABLE,
token_service_source);
- SigninManagerFactory::GetForProfile(profile_)->signin_global_error()->
- AddProvider(this);
}
-void OAuth2TokenService::Shutdown() {
- if (profile_) {
- SigninManagerFactory::GetForProfile(profile_)->signin_global_error()->
- RemoveProvider(this);
- }
-}
-
-
// static
void OAuth2TokenService::InformConsumer(
base::WeakPtr<OAuth2TokenService::RequestImpl> request,
@@ -430,10 +413,6 @@
void OAuth2TokenService::OnFetchComplete(Fetcher* fetcher) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
- // Update the auth error state so auth errors are appropriately communicated
- // to the user.
- UpdateAuthError(fetcher->error());
-
// Note |fetcher| is recorded in |pending_fetcher_| mapped to its refresh
// token and scope set. This is guaranteed as follows; here a Fetcher is said
// to be uncompleted if it has not finished calling back
@@ -520,23 +499,4 @@
// OAuth2 access tokens. If this token either changes or is cleared, any
// available tokens must be invalidated.
token_cache_.clear();
- UpdateAuthError(GoogleServiceAuthError::None());
}
-
-void OAuth2TokenService::UpdateAuthError(const GoogleServiceAuthError& error) {
- // Do not report connection errors as these are not actually auth errors.
- // We also want to avoid masking a "real" auth error just because we
- // subsequently get a transient network error.
- if (error.state() == GoogleServiceAuthError::CONNECTION_FAILED)
- return;
-
- if (error.state() != last_auth_error_.state()) {
- last_auth_error_ = error;
- SigninManagerFactory::GetForProfile(profile_)->signin_global_error()->
- AuthStatusChanged();
- }
-}
-
-GoogleServiceAuthError OAuth2TokenService::GetAuthStatus() const {
- return last_auth_error_;
-}
« no previous file with comments | « chrome/browser/signin/oauth2_token_service.h ('k') | chrome/browser/signin/oauth2_token_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698