It is not necessary to disable Visual C++ warning C4334 when

It is not necessary to disable Visual C++ warning C4334 when
compiling NSPR.

R=jschuh@chromium.org
BUG=166496
TEST=no compilation errors
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177437

[wtc, 2013-01-15 01:04:14]

jschuh: Thanks for the build instructions. I verified we
don't need to disable 4334.

D:\src\chrome3\src>ninja -C out\Debug_x64 nss
ninja: Entering directory `out\Debug_x64'
[340/574] LINK(DLL) icuuc.dll
icuuc.udata.obj : warning LNK4049: locally defined symbol icudt46_dat imported
[574/574] LINK(DLL) crnss.dll

D:\src\chrome3\src>ninja -C out\Release_x64 nss
ninja: Entering directory `out\Release_x64'
[195/574] CC obj\third_party\icu\source\common\icuuc.uinvchar.obj
icuuc.udata.obj : warning LNK4049: locally defined symbol icudt46_dat imported
[574/574] LINK(DLL) crnss.dll

[jschuh, 2013-01-15 15:16:13]

You verified that the nspr target doesn't need it (since that's where the
suppression actually is)?

[wtc, 2013-01-15 18:50:54]

Yes, I verified with the nss target, which depends on nspr.

But here is the verification you asked for:

D:\src\chrome3\src>ninja -C out\Debug_x64 nspr
ninja: Entering directory `out\Debug_x64'
[89/89] LINK(DLL) crnspr.dll

D:\src\chrome3\src>ninja -C out\Release_x64 nspr
ninja: Entering directory `out\Release_x64'
[89/89] LINK(DLL) crnspr.dll

D:\src\chrome3\src>svn diff third_party\nss
Index: third_party/nss/nss.gyp
===================================================================
--- third_party/nss/nss.gyp     (revision 175939)
+++ third_party/nss/nss.gyp     (working copy)
@@ -241,7 +241,7 @@
         ],
       },
       # TODO(wtc): suppress C4244 and C4554 in prdtoa.c.
-      'msvs_disabled_warnings': [4018, 4244, 4554, 4267, 4334,],
+      'msvs_disabled_warnings': [4018, 4244, 4554, 4267,],
       'conditions': [
         ['OS=="mac" or OS=="ios"', {
           'defines': [

[jschuh, 2013-01-17 18:10:33]

lgtm