Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1188543002: Remove LOG << "Changing alternative service". (Closed)

Created:
5 years, 6 months ago by Bence
Modified:
5 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LOG << "Changing alternative service". Remove LOG(WARNING) for changing alternative service in preparation for multiple alternative services per host. * This statement was not entirely correct to start with, because it also also got logged when no stored alternative service got modified, only the one added shadowed the alternative service of the canonical host. * With multiple alternative services per host, adding one to a host will not change an existing one. BUG=392575 Committed: https://crrev.com/e5e37f81e24845f03b43abdb964cd640ca637773 Cr-Commit-Position: refs/heads/master@{#335079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M net/http/http_server_properties_impl.cc View 1 chunk +6 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 6 months ago (2015-06-15 13:55:10 UTC) #2
Ryan Hamilton
lgtm
5 years, 6 months ago (2015-06-18 04:15:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188543002/1
5 years, 6 months ago (2015-06-18 11:46:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/2473)
5 years, 6 months ago (2015-06-18 12:00:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188543002/1
5 years, 6 months ago (2015-06-18 17:51:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 18:18:10 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 18:18:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5e37f81e24845f03b43abdb964cd640ca637773
Cr-Commit-Position: refs/heads/master@{#335079}

Powered by Google App Engine
This is Rietveld 408576698