Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: net/http/http_server_properties_impl.cc

Issue 1188543002: Remove LOG << "Changing alternative service". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_server_properties_impl.cc
diff --git a/net/http/http_server_properties_impl.cc b/net/http/http_server_properties_impl.cc
index 1f667a18f67592ea0d2802aa4a2cd74c5db44bed..f759134cb7904afc203d3c479b68814fd4813b9a 100644
--- a/net/http/http_server_properties_impl.cc
+++ b/net/http/http_server_properties_impl.cc
@@ -292,21 +292,12 @@ void HttpServerPropertiesImpl::SetAlternativeService(
alternative_service, alternative_probability);
AlternativeServiceMap::const_iterator it =
GetAlternateProtocolIterator(origin);
- if (it != alternative_service_map_.end()) {
- const AlternativeServiceInfo existing_alternative_service_info = it->second;
- if (existing_alternative_service_info != alternative_service_info) {
- LOG(WARNING) << "Changing the alternative service for: "
- << origin.ToString() << " from "
- << existing_alternative_service_info.ToString() << " to "
- << alternative_service_info.ToString() << ".";
- }
- } else {
- if (alternative_probability >= alternative_service_probability_threshold_) {
- // TODO(rch): Consider the case where multiple requests are started
- // before the first completes. In this case, only one of the jobs
- // would reach this code, whereas all of them should should have.
- HistogramAlternateProtocolUsage(ALTERNATE_PROTOCOL_USAGE_MAPPING_MISSING);
- }
+ if (it == alternative_service_map_.end() &&
+ alternative_probability >= alternative_service_probability_threshold_) {
+ // TODO(rch): Consider the case where multiple requests are started
+ // before the first completes. In this case, only one of the jobs
+ // would reach this code, whereas all of them should should have.
+ HistogramAlternateProtocolUsage(ALTERNATE_PROTOCOL_USAGE_MAPPING_MISSING);
}
alternative_service_map_.Put(origin, alternative_service_info);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698