Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/fileicon_source_unittest.cc

Issue 11885021: Don't derive from ChromeURLDataManager::DataSource, and instead have these classes implement a dele… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/webui/bookmarks_ui.cc ('K') | « chrome/browser/ui/webui/fileicon_source.cc ('k') | chrome/browser/ui/webui/ntp/new_tab_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/fileicon_source_unittest.cc
===================================================================
--- chrome/browser/ui/webui/fileicon_source_unittest.cc (revision 176443)
+++ chrome/browser/ui/webui/fileicon_source_unittest.cc (working copy)
@@ -25,7 +25,6 @@
IconLoader::IconSize icon_size,
int request_id));
- private:
virtual ~TestFileIconSource() {}
};
@@ -114,7 +113,7 @@
TEST_F(FileIconSourceTest, FileIconSource_Parse) {
for (unsigned i = 0; i < arraysize(kBasicExpectations); i++) {
- scoped_refptr<TestFileIconSource> source(CreateFileIconSource());
+ scoped_ptr<TestFileIconSource> source(CreateFileIconSource());
EXPECT_CALL(*source.get(),
FetchFileIcon(FilePath(kBasicExpectations[i].unescaped_path),
kBasicExpectations[i].scale_factor,
« chrome/browser/ui/webui/bookmarks_ui.cc ('K') | « chrome/browser/ui/webui/fileicon_source.cc ('k') | chrome/browser/ui/webui/ntp/new_tab_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698