Don't derive from ChromeURLDataManager::DataSource, and instead have these classes implement a dele…

chrome/browser/ui/webui/bookmarks_ui.cc

Index: chrome/browser/ui/webui/bookmarks_ui.cc
===================================================================
--- chrome/browser/ui/webui/bookmarks_ui.cc	(revision 176443)
+++ chrome/browser/ui/webui/bookmarks_ui.cc	(working copy)
@@ -19,17 +19,20 @@
 //
 ////////////////////////////////////////////////////////////////////////////////
 
-BookmarksUIHTMLSource::BookmarksUIHTMLSource()
-    : DataSource(chrome::kChromeUIBookmarksHost, MessageLoop::current()) {
+BookmarksUIHTMLSource::BookmarksUIHTMLSource() {
 }
 
+std::string BookmarksUIHTMLSource::GetSource() {
+  return chrome::kChromeUIBookmarksHost;
+}
+
 void BookmarksUIHTMLSource::StartDataRequest(const std::string& path,
                                              bool is_incognito,
                                              int request_id) {
   NOTREACHED() << "We should never get here since the extension should have"
                << "been triggered";
 
-  SendResponse(request_id, NULL);
+  url_data_source()->SendResponse(request_id, NULL);
 }
 
 std::string BookmarksUIHTMLSource::GetMimeType(const std::string& path) const {
@@ -48,10 +51,12 @@
 
 BookmarksUI::BookmarksUI(content::WebUI* web_ui) : WebUIController(web_ui) {
   BookmarksUIHTMLSource* html_source = new BookmarksUIHTMLSource();
-
   // Set up the chrome://bookmarks/ source.
   Profile* profile = Profile::FromWebUI(web_ui);
   ChromeURLDataManager::AddDataSource(profile, html_source);
+  ChromeURLDataManager::AddDataSource(
+      Profile::FromWebUI(web_ui),
+      new BookmarksUIHTMLSource);
 }

[tfarina, 2013/01/14 20:49:11]

wait, something is crazy going on here.


Isn't:

ChromeURLDataManager::AddDataSource(Profile::FromWebUI(web_ui), new
BookmarksUIHTMLSource);

The same of:

BookmarksUIHTMLSource* html_source = new BookmarksUIHTMLSource();
Profile* profile = Profile::FromWebUI(web_ui);
ChromeURLDataManager::AddDataSource(profile, html_source);

?

If I'm not seeing this wrong, you are doing the same thing twice here.

[jam, 2013/01/14 20:52:07]

ah, thanks. i had changed it while doing another change that i later undid, and
now i went back to make the formatting the same but forgot to remove this. will
commit in a followup

 
 // static