Issue 1188433006: Revert of Update Dart dependency and patch dart_controller to account for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1188433006: Revert of Update Dart dependency and patch dart_controller to account for (Closed)

Created:
5 years, 6 months ago by Chinmay

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium, eseidel

CC:
gregsimon, iposva, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Revert of Update Dart dependency and patch dart_controller to account for (patchset #1 id:1 of https://codereview.chromium.org/1183253002/) Reason for revert: Build Break Original issue's description: > Update Dart dependency and patch dart_controller to account for > non-backwards compatible API update > > BUG= > R=abarth@chromium.org > > Committed: https://chromium.googlesource.com/external/mojo/+/42bb335967d4d9cbeb1a745111dd0fff985465f2 TBR=abarth@chromium.org,eseidel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=

Created: 5 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sky/engine/core/script/dart_controller.cc	View		4 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 3 (1 generated)

Chinmay

Created Revert of Update Dart dependency and patch dart_controller to account for

5 years, 6 months ago (2015-06-15 22:29:58 UTC) #1

commit-bot: I haz the power

5 years, 6 months ago (2015-06-15 22:31:03 UTC) #3

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.