Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 11884017: Show a localized and detailed error page when a page load fails due to ERR_NETWORK_CHANGED. (Closed)

Created:
7 years, 11 months ago by Joao da Silva
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Show a localized and detailed error page when a page load fails due to ERR_NETWORK_CHANGED. BUG=164363 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176874

Patch Set 1 #

Total comments: 2

Patch Set 2 : using WebKit::WebURLError #

Patch Set 3 : removed cleanups #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/common/localized_error.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Joao da Silva
@mmenke: here's the custom error page for ERR_NETWORK_CHANGED, as discussed in https://codereview.chromium.org/11464028/. @jochen: chrome/ owner ...
7 years, 11 months ago (2013-01-14 13:38:31 UTC) #1
jochen (gone - plz use gerrit)
why are you mixing this CL with some random cleanups? https://codereview.chromium.org/11884017/diff/1/chrome/common/localized_error.cc File chrome/common/localized_error.cc (left): https://codereview.chromium.org/11884017/diff/1/chrome/common/localized_error.cc#oldcode29 ...
7 years, 11 months ago (2013-01-14 13:45:37 UTC) #2
Joao da Silva
Why not do cleanups as you go? (I see this being done often, let me ...
7 years, 11 months ago (2013-01-14 13:49:45 UTC) #3
jochen (gone - plz use gerrit)
On 2013/01/14 13:49:45, Joao da Silva wrote: > Why not do cleanups as you go? ...
7 years, 11 months ago (2013-01-14 13:52:50 UTC) #4
Joao da Silva
On 2013/01/14 13:52:50, jochen wrote: > On 2013/01/14 13:49:45, Joao da Silva wrote: > > ...
7 years, 11 months ago (2013-01-14 14:01:05 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 11 months ago (2013-01-14 14:21:02 UTC) #6
mmenke
LGTM, thanks for doing this!
7 years, 11 months ago (2013-01-14 17:31:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/11884017/8001
7 years, 11 months ago (2013-01-14 17:33:02 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-15 10:04:28 UTC) #9
Retried try job too often on win7_aura for step(s) browser_tests

Powered by Google App Engine
This is Rietveld 408576698