Show a localized and detailed error page when a page load fails due to ERR_NETWORK_CHANGED.

Show a localized and detailed error page when a page load fails due to ERR_NETWORK_CHANGED.

BUG=164363
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176874

[Joao da Silva, 2013-01-14 13:38:31]

@mmenke: here's the custom error page for ERR_NETWORK_CHANGED, as discussed in
https://codereview.chromium.org/11464028/.

@jochen: chrome/ owner powers :-)

Please have a look. Thanks!

[jochen (gone - plz use gerrit), 2013-01-14 13:45:37]

why are you mixing this CL with some random cleanups?

https://codereview.chromium.org/11884017/diff/1/chrome/common/localized_error.cc
File chrome/common/localized_error.cc (left):

https://codereview.chromium.org/11884017/diff/1/chrome/common/localized_error...
chrome/common/localized_error.cc:29: using WebKit::WebURLError;
please leave this in.

[Joao da Silva, 2013-01-14 13:49:45]

Why not do cleanups as you go? (I see this being done often, let me know if it's
not appropriate)

https://codereview.chromium.org/11884017/diff/1/chrome/common/localized_error.cc
File chrome/common/localized_error.cc (left):

https://codereview.chromium.org/11884017/diff/1/chrome/common/localized_error...
chrome/common/localized_error.cc:29: using WebKit::WebURLError;
On 2013/01/14 13:45:37, jochen wrote:
> please leave this in. 

Done. This was removed because the 2 out of 3 uses of WebURLError are qualified
with WebKit:: in this file.

[jochen (gone - plz use gerrit), 2013-01-14 13:52:50]

On 2013/01/14 13:49:45, Joao da Silva wrote:
> Why not do cleanups as you go? (I see this being done often, let me know if
it's
> not appropriate)
> 

It distracts the reviewer from the actual change you want to make. If you notice
style violations, feel free to fix them in a separate CL.


>
https://codereview.chromium.org/11884017/diff/1/chrome/common/localized_error.cc
> File chrome/common/localized_error.cc (left):
> 
>
https://codereview.chromium.org/11884017/diff/1/chrome/common/localized_error...
> chrome/common/localized_error.cc:29: using WebKit::WebURLError;
> On 2013/01/14 13:45:37, jochen wrote:
> > please leave this in. 
> 
> Done. This was removed because the 2 out of 3 uses of WebURLError are
qualified
> with WebKit:: in this file.

we normally don't qualify webkit symbols but use the ones we need at the top of
the file.

[Joao da Silva, 2013-01-14 14:01:05]

On 2013/01/14 13:52:50, jochen wrote:
> On 2013/01/14 13:49:45, Joao da Silva wrote:
> > Why not do cleanups as you go? (I see this being done often, let me know if
> it's
> > not appropriate)
> > 
> 
> It distracts the reviewer from the actual change you want to make. If you
notice
> style violations, feel free to fix them in a separate CL.
> 

Fair, removed the cleanups. It's a more focused CL now, PTAL :-)

> 
> >
>
https://codereview.chromium.org/11884017/diff/1/chrome/common/localized_error.cc
> > File chrome/common/localized_error.cc (left):
> > 
> >
>
https://codereview.chromium.org/11884017/diff/1/chrome/common/localized_error...
> > chrome/common/localized_error.cc:29: using WebKit::WebURLError;
> > On 2013/01/14 13:45:37, jochen wrote:
> > > please leave this in. 
> > 
> > Done. This was removed because the 2 out of 3 uses of WebURLError are
> qualified
> > with WebKit:: in this file.
> 
> we normally don't qualify webkit symbols but use the ones we need at the top
of
> the file.

[jochen (gone - plz use gerrit), 2013-01-14 14:21:02]

lgtm

[mmenke, 2013-01-14 17:31:24]

LGTM, thanks for doing this!

[commit-bot: I haz the power, 2013-01-14 17:33:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/11884017/8001

[commit-bot: I haz the power, 2013-01-15 10:04:28]

Retried try job too often on win7_aura for step(s) browser_tests