Convert all project to use common.mk

Convert all project to use common.mk

The current Makefiles are extremely large and complex.
This change puts the complexity into common.mk, nacl.mk and host.mk
so that Makefile pretty much becomes a list of sources and targets.


BUG=169044
R=binji@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177356

[noelallen1, 2013-01-16 21:58:52]

ptal

Win try bot currently down, will verify first.

[binji, 2013-01-16 22:46:54]

lgtm, mostly comment fixes.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/bui...
File native_client_sdk/src/build_tools/build_examples.py (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/bui...
native_client_sdk/src/build_tools/build_examples.py:22: help='Only\'t copy the
files, don\'t build.',
nit: s/Only\'t/Only/

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/bui...
native_client_sdk/src/build_tools/build_examples.py:55: src_path =
os.path.join(buildbot_common.SDK_SRC_DIR, 'tools', '*.mk')
could run build_sdk.BuildStepCopyBuildHelpers instead...?

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/exa...
File native_client_sdk/src/examples/debugging/example.dsc (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/exa...
native_client_sdk/src/examples/debugging/example.dsc:36: 'handler.py'
nit: remove tab

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/exa...
File native_client_sdk/src/examples/dlopen/Makefile (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/exa...
native_client_sdk/src/examples/dlopen/Makefile:15: # By default we will build a
Debug configuration using the GCC newlib toolcahin
nit: default uses glibc, not newlib

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
File native_client_sdk/src/libraries/gmock/Makefile (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
native_client_sdk/src/libraries/gmock/Makefile:38: TARGET=gtest
gmock

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
File native_client_sdk/src/libraries/gtest/Makefile (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
native_client_sdk/src/libraries/gtest/Makefile:56: # Use the link macro for this
target on the list of sources.
nit: lib macro

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
File native_client_sdk/src/libraries/ppapi_cpp/Makefile (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
native_client_sdk/src/libraries/ppapi_cpp/Makefile:35: # The base name of the
final NEXE, also the name of the NMF file containing
nit: s/NEXE/library/

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
File native_client_sdk/src/tools/common.mk (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/common.mk:96: # If no targets are specified on the
command-line, the first target listed in
this comment is wrong

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/common.mk:140: -include $(OUTDIR)/*.d
maybe give this its own header and description...?

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/common.mk:188: # macros and targets defined in
nacl.mk, otherwise use the host sepecific
comment is wrong

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
File native_client_sdk/src/tools/host_gcc.mk (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/host_gcc.mk:65: define ARCHIVE_RULE
why do you need a separate macro? Can't this all live in LIB_RULE below?

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/host_gcc.mk:107: $(call
LINER_RULE,$(OUTDIR)/$(1)$(HOST_EXT),$(foreach src,$(2),$(OUTDIR)/$(basename
$(src)).o),$(3),$(4),$(LIB_PATHS),$(5))
LINKER_RULE

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
File native_client_sdk/src/tools/host_vc.mk (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/host_vc.mk:109: $(call
LINER_RULE,$(OUTDIR)/$(1)$(HOST_EXT),$(foreach src,$(2),$(OUTDIR)/$(basename
$(src)).o),$(3),$(4),$(LIB_PATHS),$(6))
LINKER_RULE

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
File native_client_sdk/src/tools/nacl_llvm.mk (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/nacl_llvm.mk:1: # Copyright (c) 2012 The Chromium
Authors. All rights reserved.
maybe should be called nacl_pnacl instead...?

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/nacl_llvm.mk:17: # only supports the Debug
configuration for simplicity.
comment is wrong

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/nacl_llvm.mk:28: # We use the C++ compiler for
everything and then use the -Wl,-as-needed flag
comment is wrong

[noelallen1, 2013-01-16 23:21:10]

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/bui...
File native_client_sdk/src/build_tools/build_examples.py (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/bui...
native_client_sdk/src/build_tools/build_examples.py:22: help='Only\'t copy the
files, don\'t build.',
On 2013/01/16 22:46:55, binji wrote:
> nit: s/Only\'t/Only/

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/bui...
native_client_sdk/src/build_tools/build_examples.py:55: src_path =
os.path.join(buildbot_common.SDK_SRC_DIR, 'tools', '*.mk')
On 2013/01/16 22:46:55, binji wrote:
> could run build_sdk.BuildStepCopyBuildHelpers instead...?

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/exa...
File native_client_sdk/src/examples/debugging/example.dsc (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/exa...
native_client_sdk/src/examples/debugging/example.dsc:36: 'handler.py'
On 2013/01/16 22:46:55, binji wrote:
> nit: remove tab

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/exa...
File native_client_sdk/src/examples/dlopen/Makefile (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/exa...
native_client_sdk/src/examples/dlopen/Makefile:15: # By default we will build a
Debug configuration using the GCC newlib toolcahin
On 2013/01/16 22:46:55, binji wrote:
> nit: default uses glibc, not newlib

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
File native_client_sdk/src/libraries/gmock/Makefile (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
native_client_sdk/src/libraries/gmock/Makefile:38: TARGET=gtest
On 2013/01/16 22:46:55, binji wrote:
> gmock

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
File native_client_sdk/src/libraries/gtest/Makefile (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
native_client_sdk/src/libraries/gtest/Makefile:56: # Use the link macro for this
target on the list of sources.
On 2013/01/16 22:46:55, binji wrote:
> nit: lib macro

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
File native_client_sdk/src/libraries/ppapi_cpp/Makefile (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/lib...
native_client_sdk/src/libraries/ppapi_cpp/Makefile:35: # The base name of the
final NEXE, also the name of the NMF file containing
On 2013/01/16 22:46:55, binji wrote:
> nit: s/NEXE/library/

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
File native_client_sdk/src/tools/common.mk (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/common.mk:96: # If no targets are specified on the
command-line, the first target listed in
On 2013/01/16 22:46:55, binji wrote:
> this comment is wrong

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
File native_client_sdk/src/tools/host_gcc.mk (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/host_gcc.mk:65: define ARCHIVE_RULE
On 2013/01/16 22:46:55, binji wrote:
> why do you need a separate macro? Can't this all live in LIB_RULE below?

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/host_gcc.mk:107: $(call
LINER_RULE,$(OUTDIR)/$(1)$(HOST_EXT),$(foreach src,$(2),$(OUTDIR)/$(basename
$(src)).o),$(3),$(4),$(LIB_PATHS),$(5))
On 2013/01/16 22:46:55, binji wrote:
> LINKER_RULE

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
File native_client_sdk/src/tools/host_vc.mk (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/host_vc.mk:109: $(call
LINER_RULE,$(OUTDIR)/$(1)$(HOST_EXT),$(foreach src,$(2),$(OUTDIR)/$(basename
$(src)).o),$(3),$(4),$(LIB_PATHS),$(6))
On 2013/01/16 22:46:55, binji wrote:
> LINKER_RULE

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
File native_client_sdk/src/tools/nacl_llvm.mk (right):

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/nacl_llvm.mk:1: # Copyright (c) 2012 The Chromium
Authors. All rights reserved.
On 2013/01/16 22:46:55, binji wrote:
> maybe should be called nacl_pnacl instead...?

I'll do rename as a seperate CL to make it cleaner.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/nacl_llvm.mk:17: # only supports the Debug
configuration for simplicity.
On 2013/01/16 22:46:55, binji wrote:
> comment is wrong

Done.

https://codereview.chromium.org/11882012/diff/14082/native_client_sdk/src/too...
native_client_sdk/src/tools/nacl_llvm.mk:28: # We use the C++ compiler for
everything and then use the -Wl,-as-needed flag
On 2013/01/16 22:46:55, binji wrote:
> comment is wrong

Done.