Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: pkg/compiler/lib/src/closure.dart

Issue 1188103002: Do not mark type variables as needing a box inside try; they are immutable. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/closure.dart
diff --git a/pkg/compiler/lib/src/closure.dart b/pkg/compiler/lib/src/closure.dart
index 49c0eaec0eba6669f7b6559485ce84fbb58ad719..3beedab0e68ae4ffebca7e86d30ea4ce1c398e3d 100644
--- a/pkg/compiler/lib/src/closure.dart
+++ b/pkg/compiler/lib/src/closure.dart
@@ -651,7 +651,8 @@ class ClosureTranslator extends Visitor {
// things in the builder.
// Note that nested (named) functions are immutable.
if (variable != closureData.thisLocal &&
- variable != closureData.closureElement) {
+ variable != closureData.closureElement &&
+ variable is! TypeVariableLocal) {
closureData.variablesUsedInTryOrGenerator.add(variable);
}
} else if (variable is LocalParameterElement &&
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698