pkg/compiler/lib/src/ssa/builder.dart - Issue 1188103002: Do not mark type variables as needing a box inside try; they are immutable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1188103002: Do not mark type variables as needing a box inside try; they are immutable. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/ssa/builder.dart

diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart

index 0ef26591b908ce4d5ecb0c34336f8993d993030a..6870ecb53ab37ce49816bd21571ceed387ae5838 100644

--- a/pkg/compiler/lib/src/ssa/builder.dart

+++ b/pkg/compiler/lib/src/ssa/builder.dart

@@ -2446,7 +2446,8 @@ class SsaBuilder extends NewResolvedVisitor {

String name = kind == HTypeConversion.CAST_TYPE_CHECK

? '_asCheck' : '_assertCheck';

- List arguments = [buildFunctionType(type), original];

+ List<HInstruction> arguments =

+ <HInstruction>[buildFunctionType(type), original];

pushInvokeDynamic(

null,

new Selector.call(name, backend.jsHelperLibrary, 1),

« no previous file with comments | « pkg/compiler/lib/src/closure.dart ('k') | tests/language/regress_23650_test.dart » ('j') | no next file with comments »