Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 11880048: Fix crash bug when deoptimizing from an optimized sqrt operation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/arithmetic_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 17050)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -2172,6 +2172,13 @@
void StaticCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
Label skip_call;
+ if (!compiler->is_optimizing()) {
+ // Some static calls can be optimized by the optimizing compiler (e.g. sqrt)
+ // and therefore need a deoptimization descriptor.
+ compiler->AddCurrentDescriptor(PcDescriptors::kDeoptBefore,
+ deopt_id(),
+ token_pos());
+ }
if (function().name() == Symbols::EqualOperator().raw()) {
compiler->EmitSuperEqualityCallPrologue(locs()->out().reg(), &skip_call);
}
« no previous file with comments | « no previous file | tests/language/arithmetic_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698