Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: runtime/vm/intermediate_language.cc

Issue 11880048: Fix crash bug when deoptimizing from an optimized sqrt operation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/language/arithmetic_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/intermediate_language.h" 5 #include "vm/intermediate_language.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/dart_entry.h" 8 #include "vm/dart_entry.h"
9 #include "vm/flow_graph_allocator.h" 9 #include "vm/flow_graph_allocator.h"
10 #include "vm/flow_graph_builder.h" 10 #include "vm/flow_graph_builder.h"
(...skipping 2154 matching lines...) Expand 10 before | Expand all | Expand 10 after
2165 } 2165 }
2166 2166
2167 2167
2168 LocationSummary* StaticCallInstr::MakeLocationSummary() const { 2168 LocationSummary* StaticCallInstr::MakeLocationSummary() const {
2169 return MakeCallSummary(); 2169 return MakeCallSummary();
2170 } 2170 }
2171 2171
2172 2172
2173 void StaticCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 2173 void StaticCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
2174 Label skip_call; 2174 Label skip_call;
2175 if (!compiler->is_optimizing()) {
2176 // Some static calls can be optimized by the optimizing compiler (e.g. sqrt)
2177 // and therefore need a deoptimization descriptor.
2178 compiler->AddCurrentDescriptor(PcDescriptors::kDeoptBefore,
2179 deopt_id(),
2180 token_pos());
2181 }
2175 if (function().name() == Symbols::EqualOperator().raw()) { 2182 if (function().name() == Symbols::EqualOperator().raw()) {
2176 compiler->EmitSuperEqualityCallPrologue(locs()->out().reg(), &skip_call); 2183 compiler->EmitSuperEqualityCallPrologue(locs()->out().reg(), &skip_call);
2177 } 2184 }
2178 compiler->GenerateStaticCall(deopt_id(), 2185 compiler->GenerateStaticCall(deopt_id(),
2179 token_pos(), 2186 token_pos(),
2180 function(), 2187 function(),
2181 ArgumentCount(), 2188 ArgumentCount(),
2182 argument_names(), 2189 argument_names(),
2183 locs()); 2190 locs());
2184 __ Bind(&skip_call); 2191 __ Bind(&skip_call);
(...skipping 776 matching lines...) Expand 10 before | Expand all | Expand 10 after
2961 default: 2968 default:
2962 UNREACHABLE(); 2969 UNREACHABLE();
2963 return -1; 2970 return -1;
2964 } 2971 }
2965 } 2972 }
2966 2973
2967 2974
2968 #undef __ 2975 #undef __
2969 2976
2970 } // namespace dart 2977 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | tests/language/arithmetic_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698