Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 11880034: [Telemetry] Set user agent through Network.setUserAgentOverride instead of --user-agent. (Closed)

Created:
7 years, 11 months ago by hartmanng
Modified:
7 years, 10 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org, pfeldman
Visibility:
Public.

Description

[Telemetry] Set user agent through Network.setUserAgentOverride instead of --user-agent. This should fix the following user-agent-related issues: * user agent string being parsed incorrectly by dbus-send on cros -> * a few sites (Google calendar I think?) don't like this incorrect user agent, and redirect to different versions of the site * telemetry uses user agent to determine chrome version, but we manually specify user agent, so it returns a fake version -> * this causes us to incorrectly say that cros doesn't support tab control BUG=169296, 167979

Patch Set 1 #

Patch Set 2 : user agent override is working #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M tools/telemetry/telemetry/browser_backend.py View 1 2 chunks +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/inspector_page.py View 1 1 chunk +14 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/tab_backend.py View 1 2 chunks +6 lines, -0 lines 2 comments Download
M tools/telemetry/telemetry/user_agent.py View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hartmanng
Please take a look
7 years, 11 months ago (2013-01-18 16:38:25 UTC) #1
bulach
+peter lgtm but.. :) when I originally added the userAgent, I chatted with peter and ...
7 years, 11 months ago (2013-01-18 20:44:04 UTC) #2
nduca
what'd you have to do to make user agent override work btw?
7 years, 11 months ago (2013-01-22 21:43:44 UTC) #3
nduca
7 years, 11 months ago (2013-01-22 21:46:03 UTC) #4
https://codereview.chromium.org/11880034/diff/9005/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/tab_backend.py (right):

https://codereview.chromium.org/11880034/diff/9005/tools/telemetry/telemetry/...
tools/telemetry/telemetry/tab_backend.py:41: def _Connect(self):
hmmm... what if connect happens after we've navigated to the page of interest?

The more I think about this, the more we should have devtools give back the
chrome rev directly and continue to use the command line. There seem to be too
many ways for this to go wrong to me to be truly robust.

Powered by Google App Engine
This is Rietveld 408576698