[Telemetry] Set user agent through Network.setUserAgentOverride instead of --user-agent.

tools/telemetry/telemetry/tab_backend.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import json
 import logging
 import socket
 import sys
 
 from telemetry import inspector_console
 from telemetry import inspector_page
 from telemetry import inspector_runtime
 from telemetry import inspector_timeline
 from telemetry import png_bitmap
 from telemetry import tab_crash_exception
+from telemetry import user_agent
 from telemetry import util
 from telemetry import websocket
 
 class InspectorException(Exception):
   pass
 
 class TabBackend(object):
   def __init__(self, browser, browser_backend, debugger_url):
     assert debugger_url
     self._browser = browser
     self._browser_backend = browser_backend
     self._debugger_url = debugger_url
     self._socket = None
     self._domain_handlers = {}
     self._cur_socket_timeout = 0
     self._next_request_id = 0
 
     self._console = inspector_console.InspectorConsole(self)
     self._page = inspector_page.InspectorPage(self)
     self._runtime = inspector_runtime.InspectorRuntime(self)
     self._timeline = inspector_timeline.InspectorTimeline(self)
 
   def __del__(self):
     self.Disconnect()
 
   def _Connect(self):

[nduca, 2013/01/22 21:46:03]

hmmm... what if connect happens after we've navigated to the page of interest?

The more I think about this, the more we should have devtools give back the
chrome rev directly and continue to use the command line. There seem to be too
many ways for this to go wrong to me to be truly robust.

     if self._socket:
       return
     self._socket = websocket.create_connection(self._debugger_url)
     self._cur_socket_timeout = 0
     self._next_request_id = 0
 
+    user_agent_string = user_agent.GetUserAgentFromType(
+        self._browser_backend.options.browser_user_agent_type)
+    if user_agent_string is not None:

[bulach, 2013/01/18 20:44:04]

nit: s/is not None//

+      self._page.SetUserAgent(user_agent_string)
+
   def Disconnect(self):
     for _, handlers in self._domain_handlers.items():
       _, will_close_handler = handlers
       will_close_handler()
     self._domain_handlers = {}
 
     if self._socket:
       self._socket.close()
       self._socket = None
 
@@ skipping 229 matching lines @@
                                         OnConsoleNotification, OnConsoleClose)
        """
     assert domain_name not in self._domain_handlers
     self._domain_handlers[domain_name] = (notification_handler,
                                           will_close_handler)
 
   def UnregisterDomain(self, domain_name):
     """Unregisters a previously registered domain."""
     assert domain_name in self._domain_handlers
     self._domain_handlers.pop(domain_name)