Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(93)

Issue 11880024: Merge 139479 (Closed)

Created:
7 years, 9 months ago by leviw_travelin_and_unemployed
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139479 > RenderGeometryMap and TransformState disagree with sub-pixel layout and translations > https://bugs.webkit.org/show_bug.cgi?id=106047 > > Reviewed by Simon Fraser. > > Source/WebCore: > > Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState. > This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap > pixel-snapped later when a translation occurred between two sub-pixel containers. > > Test: fast/layers/geometry-map-transform-state-translation-mismatch.html > > * platform/graphics/transforms/TransformState.h: > (WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new quad. Note: this > implementation only works properly when only tracking a quad. > * platform/graphics/transforms/TransformState.cpp: > (WebCore::TransformState::applyTransform): apply integral translations to the accumulatedOffset > for performance and consistency with RenderGeometryMap. > > LayoutTests: > > * fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added. > * fast/layers/geometry-map-transform-state-translation-mismatch.html: Added. > TBR=leviw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, --1 lines) Patch
A + LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/platform/graphics/transforms/TransformState.h View 1 chunk +8 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/transforms/TransformState.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
leviw_travelin_and_unemployed
7 years, 9 months ago (2013-01-14 17:37:25 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698