Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1187933002: Fix running package.py on Windows after https://codereview.chromium.org/1169353002 (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix running package.py on Windows after https://codereview.chromium.org/1169353002 The explicit copied env seems to mess with running cmake, probably because the setenv.cmd call won't have the same effect in this case. (cmake just dies without any output though -- it stops dying with this change here.) Also change update.py to not buffer stdout at all, so that update.py's output makes sense combined with the output of its child processes. BUG=494442 R=hans@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/49b3379f00a2e0a2947f43205c1cb00946ee1878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/clang/scripts/update.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Nico
5 years, 6 months ago (2015-06-15 21:31:26 UTC) #2
hans
lgtm
5 years, 6 months ago (2015-06-15 21:34:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187933002/1
5 years, 6 months ago (2015-06-15 21:36:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/86094) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 6 months ago (2015-06-15 21:42:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187933002/1
5 years, 6 months ago (2015-06-15 21:45:46 UTC) #9
Nico
5 years, 6 months ago (2015-06-15 22:27:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49b3379f00a2e0a2947f43205c1cb00946ee1878 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698