update.py: Check out and build libc++ libc++abi on OS X, set deployment target.

update.py: Check out and build libc++ libc++abi on OS X, set deployment target.

I had hoped to bump the deployment target to 10.7 instead, but the nacl bots
still build on 10.6 :-(

Also, pass commands as a single string to subprocess when
shell=True (else, 2nd cmd entry and onward are treated as
shell parameters, not as part of the command).

BUG=494442
Committed: https://crrev.com/8fe06c48bbe07670dba3cafdd4c613f0008948f9
Cr-Commit-Position: refs/heads/master@{#333669}

R=hans@chromium.org

[Nico, 2015-06-09 23:29:54]

thakis@chromium.org changed reviewers:
+ hans@chromium.org

[Nico, 2015-06-09 23:30:34]

https://codereview.chromium.org/1169353002/diff/20001/tools/clang/scripts/upd...
File tools/clang/scripts/update.sh (left):

https://codereview.chromium.org/1169353002/diff/20001/tools/clang/scripts/upd...
tools/clang/scripts/update.sh:486: CPPFLAGS="${CFLAGS}"
This is apparently no longer needed. A local --bootstrap build seems to work
without this. Probably a remnant from the configure/make days.

[hans, 2015-06-09 23:57:46]

lgtm

https://codereview.chromium.org/1169353002/diff/20001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/1169353002/diff/20001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:113: svn_info = subprocess.check_output('svn info
' + svn_repo, shell=True)
Living and learning..

https://codereview.chromium.org/1169353002/diff/20001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:135: if subprocess.call(' '.join(command),
env=env, shell=True) == 0:
I guess this makes us fail if we ever have files with spaces anywhere :-/

https://codereview.chromium.org/1169353002/diff/20001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:299: cxx = os.environ.get('CXX')
do we really need this?

[Nico, 2015-06-10 00:03:16]

https://codereview.chromium.org/1169353002/diff/20001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/1169353002/diff/20001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:299: cxx = os.environ.get('CXX')
On 2015/06/09 23:57:45, hans wrote:
> do we really need this?

guess not. removed, thanks.

[Nico, 2015-06-10 00:16:03]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-06-10 00:16:03]

The patchset sent to the CQ was uploaded after l-g-t-m from hans@chromium.org
Link to the patchset: https://codereview.chromium.org/1169353002/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2015-06-10 00:17:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169353002/40001

[commit-bot: I haz the power, 2015-06-10 03:10:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-10 03:11:26]

Patchset 3 (id:??) landed as
https://crrev.com/8fe06c48bbe07670dba3cafdd4c613f0008948f9
Cr-Commit-Position: refs/heads/master@{#333669}

[Nico, 2015-06-10 15:27:03]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1172363002/ by thakis@chromium.org.

The reason for reverting is: broke clang/win tot bots.

[Nico, 2015-06-14 22:28:19]

Trying this again, see diff from 3 to 4 to see what changed. The Win bots
complained:

  Parse error in command line argument: -DLLVM_FORCE_HEAD_REVISION
  Should be: VAR:type=value

That's because of the `" ".join(command)` change in RunCommand(). To make this
work for arguments that contain spaces, I now pipes.quote() each argument. This
exposed a few places where I was playing loose with string/list conversions, so
I made cflags & co lists instead of strings (which seems better anyways). Those
are just ' '.join()ed for now; if we ever have cflags containing spaces we can
make this more correct then. I also switched to using the glob module instead of
relying on the shell to expand "*.cpp".

[Nico, 2015-06-14 22:28:31]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-06-14 22:28:32]

The patchset sent to the CQ was uploaded after l-g-t-m from hans@chromium.org
Link to the patchset: https://codereview.chromium.org/1169353002/#ps60001
(title: "try to not break windows")

[commit-bot: I haz the power, 2015-06-14 22:28:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169353002/60001

[Nico, 2015-06-14 23:41:32]

Committed patchset #4 (id:60001) to pending queue manually as
8aff533dc6e39b3e3c09f0dd456a4d384e90dc00 (presubmit successful).