CrOS: Prefer discarding internal web UI pages when out of memory

CrOS: Prefer discarding internal web UI pages when out of memory

Discard the NTP, Settings, History and downloads pages first when the OS runs
out of physical memory. These pages are stateless and quick to reload when the
tab is selected.

BUG=166891
TEST=Added to unit_tests for OomPriorityManager


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176981

[James Cook, 2013-01-15 00:50:25]

Greg, PTAL.

[Greg Spencer (Chromium), 2013-01-15 00:54:47]

LGTM w/nit

https://codereview.chromium.org/11879029/diff/1/chrome/browser/chromeos/memor...
File chrome/browser/chromeos/memory/oom_priority_manager.cc (right):

https://codereview.chromium.org/11879029/diff/1/chrome/browser/chromeos/memor...
chrome/browser/chromeos/memory/oom_priority_manager.cc:204: str +=
ASCIIToUTF16(it->is_reloadable_ui ? " discardable_ui" : "");
shouldn't the string be "reloadable_ui" to match?

[commit-bot: I haz the power, 2013-01-15 19:42:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/11879029/6001

[commit-bot: I haz the power, 2013-01-15 19:48:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/11879029/6001

[commit-bot: I haz the power, 2013-01-15 22:10:22]

Change committed as 176981

[Dan Beam, 2016-06-01 17:30:36]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-06-01 17:30:36]

https://chromiumcodereview.appspot.com/11879029/diff/6001/chrome/browser/chro...
File chrome/browser/chromeos/memory/oom_priority_manager.cc (right):

https://chromiumcodereview.appspot.com/11879029/diff/6001/chrome/browser/chro...
chrome/browser/chromeos/memory/oom_priority_manager.cc:249:
chrome::kChromeUISettingsURL,
why wouldn't we use WebUIControllerFactoryRegistry::UseWebUIForURL() instead of
this half-baked list?

[James Cook, 2016-06-01 17:44:31]

On 2016/06/01 17:30:36, Dan Beam wrote:
>
https://chromiumcodereview.appspot.com/11879029/diff/6001/chrome/browser/chro...
> File chrome/browser/chromeos/memory/oom_priority_manager.cc (right):
> 
>
https://chromiumcodereview.appspot.com/11879029/diff/6001/chrome/browser/chro...
> chrome/browser/chromeos/memory/oom_priority_manager.cc:249:
> chrome::kChromeUISettingsURL,
> why wouldn't we use WebUIControllerFactoryRegistry::UseWebUIForURL() instead
of
> this half-baked list?

I probably didn't know that function existed 3 years ago when I wrote the patch.
Feel free to change it.

[groby-ooo-7-16, 2016-06-02 01:47:17]

On 2016/06/01 17:30:36, Dan Beam wrote:
>
https://chromiumcodereview.appspot.com/11879029/diff/6001/chrome/browser/chro...
> File chrome/browser/chromeos/memory/oom_priority_manager.cc (right):
> 
>
https://chromiumcodereview.appspot.com/11879029/diff/6001/chrome/browser/chro...
> chrome/browser/chromeos/memory/oom_priority_manager.cc:249:
> chrome::kChromeUISettingsURL,
> why wouldn't we use WebUIControllerFactoryRegistry::UseWebUIForURL() instead
of
> this half-baked list?

Since nothing in life is ever easy: UseWebUIForURL depends on a browser_context,
which we don't have when this is called. But since it's already been
copy/pasta'd, I'm at least factoring it out into a shared function:
https://codereview.chromium.org/2034573002

Further cleanup welcome ;)