Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: chrome/browser/media/webrtc_internals_unittest.cc

Issue 11876007: Connecting webrtc-internals WebUI frontend with the backend (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@main
Patch Set: fix vrk's comment Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc_internals_unittest.cc
diff --git a/content/browser/media/webrtc_internals_unittest.cc b/chrome/browser/media/webrtc_internals_unittest.cc
similarity index 73%
rename from content/browser/media/webrtc_internals_unittest.cc
rename to chrome/browser/media/webrtc_internals_unittest.cc
index 52064436e2dea782342222d65639370d4a417837..87b45781cc1a26ed2c1a9ab91af659dd8e01b551 100644
--- a/content/browser/media/webrtc_internals_unittest.cc
+++ b/chrome/browser/media/webrtc_internals_unittest.cc
@@ -5,14 +5,17 @@
#include "base/memory/scoped_ptr.h"
#include "base/message_loop.h"
#include "base/values.h"
-#include "content/browser/media/webrtc_internals.h"
-#include "content/browser/media/webrtc_internals_ui_observer.h"
-#include "content/common/media/peer_connection_tracker_messages.h"
+#include "chrome/browser/media/webrtc_internals.h"
+#include "chrome/browser/media/webrtc_internals_ui_observer.h"
#include "content/public/test/test_browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
-namespace content {
-class MockWebRTCInternalsProxy : public content::WebRTCInternalsUIObserver {
+namespace media {
+static const std::string kContraints = "c";
+static const std::string kServers = "s";
+static const std::string kUrl = "u";
+
+class MockWebRTCInternalsProxy : public WebRTCInternalsUIObserver {
public:
void OnUpdate(const std::string& command, const Value* value) OVERRIDE {
data_ = command;
@@ -36,14 +39,6 @@ class WebRTCInternalsTest : public testing::Test {
webrtc_internals_ = WebRTCInternals::GetInstance();
}
- PeerConnectionInfo GetPeerConnectionInfo(uintptr_t lid) {
- PeerConnectionInfo info;
- info.lid = lid;
- info.servers = "s";
- info.constraints = "c";
- info.url = "u";
- return info;
- }
std::string ExpectedInfo(std::string prefix,
std::string id,
std::string suffix) {
@@ -68,7 +63,7 @@ TEST_F(WebRTCInternalsTest, AddRemoveObserver) {
new MockWebRTCInternalsProxy());
webrtc_internals_->AddObserver(observer.get());
webrtc_internals_->RemoveObserver(observer.get());
- webrtc_internals_->AddPeerConnection(3, GetPeerConnectionInfo(4));
+ webrtc_internals_->AddPeerConnection(3, 4, kUrl, kServers, kContraints);
EXPECT_EQ("", observer->data());
webrtc_internals_->RemovePeerConnection(3, 4);
@@ -78,8 +73,8 @@ TEST_F(WebRTCInternalsTest, SendAddPeerConnectionUpdate) {
scoped_ptr<MockWebRTCInternalsProxy> observer(
new MockWebRTCInternalsProxy());
webrtc_internals_->AddObserver(observer.get());
- webrtc_internals_->AddPeerConnection(1, GetPeerConnectionInfo(2));
- EXPECT_EQ("updatePeerConnectionAdded", observer->data());
+ webrtc_internals_->AddPeerConnection(1, 2, kUrl, kServers, kContraints);
+ EXPECT_EQ("addPeerConnection", observer->data());
webrtc_internals_->RemoveObserver(observer.get());
webrtc_internals_->RemovePeerConnection(1, 2);
@@ -89,11 +84,11 @@ TEST_F(WebRTCInternalsTest, SendRemovePeerConnectionUpdate) {
scoped_ptr<MockWebRTCInternalsProxy> observer(
new MockWebRTCInternalsProxy());
webrtc_internals_->AddObserver(observer.get());
- webrtc_internals_->AddPeerConnection(1, GetPeerConnectionInfo(2));
+ webrtc_internals_->AddPeerConnection(1, 2, kUrl, kServers, kContraints);
webrtc_internals_->RemovePeerConnection(1, 2);
- EXPECT_EQ("updatePeerConnectionRemoved", observer->data());
+ EXPECT_EQ("removePeerConnection", observer->data());
webrtc_internals_->RemoveObserver(observer.get());
}
-} // namespace content
+} // namespace media

Powered by Google App Engine
This is Rietveld 408576698