Connecting webrtc-internals WebUI frontend with the backend

content/public/browser/webrtc_internals_interface.h

Index: content/public/browser/webrtc_internals_interface.h
diff --git a/content/public/browser/webrtc_internals_interface.h b/content/public/browser/webrtc_internals_interface.h
new file mode 100644
index 0000000000000000000000000000000000000000..7a41278f5ec974b21aff83338faed28c841b4c2a
--- /dev/null
+++ b/content/public/browser/webrtc_internals_interface.h
@@ -0,0 +1,33 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_WEBRTC_INTERNALS_INTERFACE_H_
+#define CONTENT_PUBLIC_BROWSER_WEBRTC_INTERNALS_INTERFACE_H_
+
+#include "base/process.h"
+
+namespace content {
+// This interface is used to receive WebRTC updates.
+// An embedder may implement it and return it from ContentBrowserClient.
+class WebRTCInternalsInterface {

[jam, 2013/01/16 16:55:46]

nit: interface is redundant. it's also not used elsewhere in the content api.
something like WebRTCObserver is more common.

[jiayl, 2013/01/16 17:08:53]

I didn't call it WebRtcObserver because
 1. we already have a WebRTCUIObserver representing a webrtc-internals page.
It'll be confusing to have a WebRtcObserver at the same time.
 2. the WebUI impl will eventually be entirely moved into 'content/' and
WebRTCInternalsInterface will be removed at that point. So I think it is fine
to call it WebRTCInternalsInterface for now.

+ public:
+  // This method is called when a PeerConnection is created.
+  // |pid| is the renderer process id, |lid| is the renderer local id used to

[jam, 2013/01/16 16:55:46]

where does local id come from? it's the first time i hear that

[jiayl, 2013/01/16 17:08:53]

It's assigned to each PeerConnection by PeerConnectionTracker. See
PeerConnectionTracker::GetNextLocalID.

+  // identify a PeerConnection, |url| is the url of the tab owning the
+  // PeerConnection, |servers| is the servers configuration, |constraints| is
+  // the media constraints used to initialize the PeerConnection.
+  virtual void AddPeerConnection(base::ProcessId pid,
+                                 int lid,
+                                 const std::string& url,
+                                 const std::string& servers,
+                                 const std::string& constraints) = 0;
+
+  // This method is called when PeerConnection is destroyed.
+  // |pid| is the renderer process id, |lid| is the renderer local id.
+  virtual void RemovePeerConnection(base::ProcessId pid, int lid) = 0;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_WEBRTC_INTERNALS_INTERFACE_H_