Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: sky/examples/stocks2/lib/stock_row.dart

Issue 1187563006: StockRow height, background color updates (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Plumb background color Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/examples/stocks2/lib/stock_row.dart
diff --git a/sky/examples/stocks2/lib/stock_row.dart b/sky/examples/stocks2/lib/stock_row.dart
index 7c063582fb2ff1d56f7153b152c01a178d642290..e9591622c0ab693eb31e9be8f57167586aa52644 100644
--- a/sky/examples/stocks2/lib/stock_row.dart
+++ b/sky/examples/stocks2/lib/stock_row.dart
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-import 'dart:sky' as sky;
-
import 'package:sky/rendering/box.dart';
import 'package:sky/theme2/typography.dart' as typography;
import 'package:sky/widgets/ink_well.dart';
@@ -19,7 +17,7 @@ class StockRow extends Component {
final Stock stock;
- static const double kHeight = 70.0;
+ static const double kHeight = 79.0;
Hixie 2015/06/15 17:54:39 We should figure out how to dynamically measure th
hansmuller 2015/06/15 18:29:08 I agree. We shouldn't be wiring down the heights o
UINode build() {
String lastSale = "\$${stock.lastSale.toStringAsFixed(2)}";
@@ -48,7 +46,7 @@ class StockRow extends Component {
height: kHeight,
decoration: const BoxDecoration(
border: const Border(
- bottom: const BorderSide(color: const sky.Color(0xFFF4F4F4)))),
+ bottom: const BorderSide(color: const Color(0xFFF4F4F4)))),
child: new Flex(children)
)
);

Powered by Google App Engine
This is Rietveld 408576698