Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: sky/examples/stocks2/lib/stock_list.dart

Issue 1187563006: StockRow height, background color updates (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Plumb background color Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/examples/stocks2/lib/stock_row.dart » ('j') | sky/examples/stocks2/lib/stock_row.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/stocks2/lib/stock_list.dart
diff --git a/sky/examples/stocks2/lib/stock_list.dart b/sky/examples/stocks2/lib/stock_list.dart
index 0bf3673614773d39f60e61cef59e684ec2ab2f2f..a205b0b96850271954417a891531ce5c6396b01b 100644
--- a/sky/examples/stocks2/lib/stock_list.dart
+++ b/sky/examples/stocks2/lib/stock_list.dart
@@ -14,7 +14,7 @@ class Stocklist extends FixedHeightScrollable {
Object key,
this.stocks,
this.query
- }) : super(itemHeight: StockRow.kHeight, key: key);
+ }) : super(itemHeight: StockRow.kHeight, backgroundColor: const Color(0xFFFFFFFF), key: key);
Hixie 2015/06/15 17:54:39 Why is the default material background colour not
abarth-chromium 2015/06/15 18:02:18 I suspect the stocks1 app is wrong and we should u
hansmuller 2015/06/15 18:29:08 OK. I've left the backgroundColor plumbing in plac
String query;
List<Stock> stocks;
« no previous file with comments | « no previous file | sky/examples/stocks2/lib/stock_row.dart » ('j') | sky/examples/stocks2/lib/stock_row.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698