sky/examples/stocks2/lib/stock_list.dart - Issue 1187563006: StockRow height, background color updates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/examples/stocks2/lib/stock_list.dart

Issue 1187563006: StockRow height, background color updates (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Plumb background color Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/examples/stocks2/lib/stock_list.dart

diff --git a/sky/examples/stocks2/lib/stock_list.dart b/sky/examples/stocks2/lib/stock_list.dart

index 0bf3673614773d39f60e61cef59e684ec2ab2f2f..a205b0b96850271954417a891531ce5c6396b01b 100644

--- a/sky/examples/stocks2/lib/stock_list.dart

+++ b/sky/examples/stocks2/lib/stock_list.dart

@@ -14,7 +14,7 @@ class Stocklist extends FixedHeightScrollable {

Object key,

this.stocks,

this.query

- }) : super(itemHeight: StockRow.kHeight, key: key);

+ }) : super(itemHeight: StockRow.kHeight, backgroundColor: const Color(0xFFFFFFFF), key: key);

Hixie 2015/06/15 17:54:39 Why is the default material background colour not

abarth-chromium 2015/06/15 18:02:18 I suspect the stocks1 app is wrong and we should u

hansmuller 2015/06/15 18:29:08 OK. I've left the backgroundColor plumbing in plac

String query;

List<Stock> stocks;