StockRow height, background color updates

sky/examples/stocks2/lib/stock_list.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 import 'package:sky/widgets/fixed_height_scrollable.dart';
 import 'package:sky/widgets/basic.dart';
 
 import 'stock_data.dart';
 import 'stock_row.dart';
 
 class Stocklist extends FixedHeightScrollable {
 
   Stocklist({
     Object key,
     this.stocks,
     this.query
-  }) : super(itemHeight: StockRow.kHeight, key: key);
+  }) : super(itemHeight: StockRow.kHeight, backgroundColor: const Color(0xFFFFFFFF), key: key);

[Hixie, 2015/06/15 17:54:39]

Why is the default material background colour not better?

[abarth-chromium, 2015/06/15 18:02:18]

I suspect the stocks1 app is wrong and we should use the default material color.

[hansmuller, 2015/06/15 18:29:08]

OK. I've left the backgroundColor plumbing in place, let me know if you'd rather
I backed it out.

 
   String query;
   List<Stock> stocks;
 
   void syncFields(Stocklist source) {
     query = source.query;
     stocks = source.stocks;
     super.syncFields(source);
   }
 
   List<UINode> buildItems(int start, int count) {
     var filteredStocks = stocks.where((stock) {
       return query == null ||
              stock.symbol.contains(new RegExp(query, caseSensitive: false));
     });
     itemCount = filteredStocks.length;
     return filteredStocks
       .skip(start)
       .take(count)
       .map((stock) => new StockRow(stock: stock))
       .toList(growable: false);
   }
 }