We are increasing verbosity level for debug stub log messages. Now in order to see them in the log…

chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc

Index: chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc
===================================================================
--- chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc	(revision 176797)
+++ chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc	(working copy)
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 #include "base/command_line.h"
+#include "base/environment.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/string_number_conversions.h"
@@ -48,10 +49,13 @@
 void NaClGdbDebugStubTest::RunDebugStubTest(const std::string& nacl_module,
                                             const std::string& test_name) {
   base::ProcessHandle test_script;
+  scoped_ptr<base::Environment> env(base::Environment::Create());
   NaClBrowser::GetInstance()->SetGdbDebugStubPortListener(
       base::Bind(&NaClGdbDebugStubTest::StartTestScript,
                  base::Unretained(this), &test_script, test_name));
+  env->SetVar("NACLVERBOSITY", "1");

[Mark Seaborn, 2013/01/15 17:47:55]

Please add a comment to say that this turns on debug stub logging.

This is not thread safe (though it shouldn't crash).  I don't think
browser_tests are expected to run concurrently in the same process, but can you
check?  If that's the case, then LGTM.

Also please start the commit message with a 1-line summary that makes sense
without any context, e.g. "NaCl test: Explicitly enable GDB debug stub logging
via env var"

[halyavin, 2013/01/16 08:34:19]

Done
I looked into sharding supervisor. Sharding uses processes to run test in
parallel.
Done

   RunTestViaHTTP(nacl_module);
+  env->UnSetVar("NACLVERBOSITY");
   NaClBrowser::GetInstance()->ClearGdbDebugStubPortListener();
   int exit_code;
   base::WaitForExitCode(test_script, &exit_code);