We are increasing verbosity level for debug stub log messages. Now in order to see them in the log…

chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
+#include "base/environment.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/string_number_conversions.h"
 #include "chrome/browser/nacl_host/nacl_browser.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/ppapi/ppapi_test.h"
 #include "content/public/test/test_utils.h"
 
 class NaClGdbDebugStubTest : public PPAPINaClNewlibTest {
  public:
@@ skipping 25 matching lines @@
   cmd.AppendArgPath(script);
   cmd.AppendArg(base::IntToString(debug_stub_port));
   cmd.AppendArg(test_name);
   LOG(INFO) << cmd.GetCommandLineString();
   base::LaunchProcess(cmd, base::LaunchOptions(), test_process);
 }
 
 void NaClGdbDebugStubTest::RunDebugStubTest(const std::string& nacl_module,
                                             const std::string& test_name) {
   base::ProcessHandle test_script;
+  scoped_ptr<base::Environment> env(base::Environment::Create());
   NaClBrowser::GetInstance()->SetGdbDebugStubPortListener(
       base::Bind(&NaClGdbDebugStubTest::StartTestScript,
                  base::Unretained(this), &test_script, test_name));
+  env->SetVar("NACLVERBOSITY", "1");

[Mark Seaborn, 2013/01/15 17:47:55]

Please add a comment to say that this turns on debug stub logging.

This is not thread safe (though it shouldn't crash).  I don't think
browser_tests are expected to run concurrently in the same process, but can you
check?  If that's the case, then LGTM.

Also please start the commit message with a 1-line summary that makes sense
without any context, e.g. "NaCl test: Explicitly enable GDB debug stub logging
via env var"

[halyavin, 2013/01/16 08:34:19]

Done
I looked into sharding supervisor. Sharding uses processes to run test in
parallel.
Done

   RunTestViaHTTP(nacl_module);
+  env->UnSetVar("NACLVERBOSITY");
   NaClBrowser::GetInstance()->ClearGdbDebugStubPortListener();
   int exit_code;
   base::WaitForExitCode(test_script, &exit_code);
   EXPECT_EQ(0, exit_code);
 }
 
 // NaCl tests are disabled under ASAN because of qualification test.
 #if defined(ADDRESS_SANITIZER)
 # define MAYBE_Empty DISABLED_Empty
 # define MAYBE_Breakpoint DISABLED_Breakpoint
 #else
 # define MAYBE_Empty Empty
 # define MAYBE_Breakpoint Breakpoint
 #endif
 
 IN_PROC_BROWSER_TEST_F(NaClGdbDebugStubTest, MAYBE_Empty) {
   RunDebugStubTest("Empty", "continue");
 }
 
 IN_PROC_BROWSER_TEST_F(NaClGdbDebugStubTest, MAYBE_Breakpoint) {
   RunDebugStubTest("Empty", "breakpoint");
 }