We are increasing verbosity level for debug stub log messages. Now in order to see them in the log…

NaCl test: Explicitly enable GDB debug stub logging via environment variable.

We are increasing verbosity level for debug stub log messages.  Now in order to see them in the log,
we need to pass verbosity option to Native Client module.

The NaCl side of the change is here: https://codereview.chromium.org/11881048/

BUG= none
TEST= NaClGdbDebugStubTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177126

[Mark Seaborn, 2013-01-15 17:47:55]

https://codereview.chromium.org/11875038/diff/1/chrome/browser/nacl_host/test...
File chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc (right):

https://codereview.chromium.org/11875038/diff/1/chrome/browser/nacl_host/test...
chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc:56:
env->SetVar("NACLVERBOSITY", "1");
Please add a comment to say that this turns on debug stub logging.

This is not thread safe (though it shouldn't crash).  I don't think
browser_tests are expected to run concurrently in the same process, but can you
check?  If that's the case, then LGTM.

Also please start the commit message with a 1-line summary that makes sense
without any context, e.g. "NaCl test: Explicitly enable GDB debug stub logging
via env var"

[halyavin, 2013-01-16 08:34:19]

https://codereview.chromium.org/11875038/diff/1/chrome/browser/nacl_host/test...
File chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc (right):

https://codereview.chromium.org/11875038/diff/1/chrome/browser/nacl_host/test...
chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc:56:
env->SetVar("NACLVERBOSITY", "1");
On 2013/01/15 17:47:55, Mark Seaborn wrote:
> Please add a comment to say that this turns on debug stub logging.
Done
> 
> This is not thread safe (though it shouldn't crash).  I don't think
> browser_tests are expected to run concurrently in the same process, but can
you
> check?  If that's the case, then LGTM.
I looked into sharding supervisor. Sharding uses processes to run test in
parallel.
> 
> Also please start the commit message with a 1-line summary that makes sense
> without any context, e.g. "NaCl test: Explicitly enable GDB debug stub logging
> via env var"
Done

[commit-bot: I haz the power, 2013-01-16 08:36:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/halyavin@google.com/11875038/4001

[commit-bot: I haz the power, 2013-01-16 10:37:05]

Change committed as 177126