Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 1187173005: Plumb through out_row byte length so we can assert we stay underneath it. (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Plumb through out_row byte length so we can assert we stay underneath it. Sadly, not asserting for me yet. Can't hurt. BUG=chromium:491660 Committed: https://skia.googlesource.com/skia/+/cd08effd005225915c7516883f658f21dbd82292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M src/core/SkConvolver.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkConvolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkBitmapFilter_opts_SSE2.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/opts/SkBitmapFilter_opts_SSE2.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M src/opts/SkBitmapProcState_arm_neon.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187173005/1
4 years, 5 months ago (2015-06-18 16:04:48 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2015-06-18 16:10:39 UTC) #4
mtklein_C
4 years, 5 months ago (2015-06-18 16:39:28 UTC) #6
reed1
lgtm
4 years, 5 months ago (2015-06-18 17:19:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187173005/1
4 years, 5 months ago (2015-06-18 17:29:50 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2015-06-18 17:30:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cd08effd005225915c7516883f658f21dbd82292

Powered by Google App Engine
This is Rietveld 408576698