src/core/SkConvolver.h - Issue 1187173005: Plumb through out_row byte length so we can assert we stay underneath it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkConvolver.h

Issue 1187173005: Plumb through out_row byte length so we can assert we stay underneath it. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkConvolver.h

diff --git a/src/core/SkConvolver.h b/src/core/SkConvolver.h

index 8e53da2d4231befebe3f534309b9aba99bb01d24..21419a94005468e138ad74271546f83333b0603b 100644

--- a/src/core/SkConvolver.h

+++ b/src/core/SkConvolver.h

@@ -153,7 +153,8 @@ typedef void (*SkConvolveVertically_pointer)(

typedef void (*SkConvolve4RowsHorizontally_pointer)(

const unsigned char* srcData[4],

const SkConvolutionFilter1D& filter,

- unsigned char* outRow[4]);

+ unsigned char* outRow[4],

+ size_t outRowBytes);

typedef void (*SkConvolveHorizontally_pointer)(

const unsigned char* srcData,

const SkConvolutionFilter1D& filter,

« no previous file with comments | « no previous file | src/core/SkConvolver.cpp » ('j') | no next file with comments »