Issue 1187153002: Places demo game in a OneChildRenderObjectWrapper and adds a star field and nebula for background

Issue 1187153002: Places demo game in a OneChildRenderObjectWrapper and adds a star field and nebula for background (Closed)

Created:
5 years, 6 months ago by viktorl

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Places demo game in a OneChildRenderObjectWrapper and adds a star field and nebula for background R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8326c8d835b105bbe0a256338c9120fd0f2341d0

Total comments: 8

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+155 lines, -8 lines)			Patch
M	sky/examples/game/lib/game_demo_box.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/examples/game/lib/game_demo_world.dart	View	8 chunks	+114 lines, -6 lines	0 comments	Download
M	sky/examples/game/main.dart	View	2 chunks	+41 lines, -1 line	8 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

LGTM Last night I changed the names of a bunch of the objects you were ...

5 years, 6 months ago (2015-06-16 17:37:01 UTC) #3

viktorl

5 years, 6 months ago (2015-06-16 17:59:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8326c8d835b105bbe0a256338c9120fd0f2341d0 (presubmit successful).