Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1187063003: Fix -INT_MIN integer overflow in itoa_r(). (Closed)

Created:
5 years, 6 months ago by Thiemo Nagel
Modified:
5 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix -INT_MIN integer overflow in itoa_r(). BUG=None Committed: https://crrev.com/ac4d28e9cb934e01ff16a9e67a5f387caa82719f Cr-Commit-Position: refs/heads/master@{#335702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M base/debug/stack_trace_posix.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/third_party/symbolize/symbolize.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Thiemo Nagel
And another one... :)
5 years, 6 months ago (2015-06-17 13:28:58 UTC) #2
Thiemo Nagel
Covered by StackTraceTest.itoa_r unit test.
5 years, 6 months ago (2015-06-23 09:26:30 UTC) #3
brettw
lgtm
5 years, 6 months ago (2015-06-23 16:52:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187063003/1
5 years, 6 months ago (2015-06-23 16:58:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/23362)
5 years, 6 months ago (2015-06-23 17:27:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187063003/1
5 years, 6 months ago (2015-06-23 17:54:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 18:16:41 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 18:17:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac4d28e9cb934e01ff16a9e67a5f387caa82719f
Cr-Commit-Position: refs/heads/master@{#335702}

Powered by Google App Engine
This is Rietveld 408576698