base/third_party/symbolize/symbolize.cc - Issue 1187063003: Fix -INT_MIN integer overflow in itoa_r().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/third_party/symbolize/symbolize.cc

Issue 1187063003: Fix -INT_MIN integer overflow in itoa_r(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/third_party/symbolize/symbolize.cc

diff --git a/base/third_party/symbolize/symbolize.cc b/base/third_party/symbolize/symbolize.cc

index b25f7479d0df09f0c9dd87637df1a929124fed41..f4861dfe523e7cd7e157603fddb4da6d513c688a 100644

--- a/base/third_party/symbolize/symbolize.cc

+++ b/base/third_party/symbolize/symbolize.cc

@@ -651,7 +651,8 @@ char *itoa_r(intptr_t i, char *buf, size_t sz, int base, size_t padding) {

// Handle negative numbers (only for base 10).

if (i < 0 && base == 10) {

- j = -i;

+ // This does "j = -i" while avoiding integer overflow.

+ j = static_cast<uintptr_t>(-(i + 1)) + 1;

// Make sure we can write the '-' character.

if (++n > sz) {

« no previous file with comments | « base/debug/stack_trace_posix.cc ('k') | no next file » | no next file with comments »