Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1187063002: MIPS: Fix for Remove unsafe EmitLoadRegister usage in AddI/SubI for constant right operand. (Closed)

Created:
5 years, 6 months ago by paul.l...
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix for Remove unsafe EmitLoadRegister usage in AddI/SubI for constant right operand. Fix a missed addiu->Addu, and a bad default use of 'at' register in https://codereview.chromium.org/1185143002/ TEST=test/mjsunit/regress/regress-500176 BUG=chromium:500176 LOG=N Committed: https://crrev.com/879053a59c426e84f355b9ee03dc3b4e6f9ccc1f Cr-Commit-Position: refs/heads/master@{#29034}

Patch Set 1 #

Patch Set 2 : Specify scratch reg to Overflow macros, to avoid 'at' reg conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
akos.palfi.imgtec
Lgtm
5 years, 6 months ago (2015-06-16 00:37:12 UTC) #2
paul.l...
5 years, 6 months ago (2015-06-16 02:06:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187063002/20001
5 years, 6 months ago (2015-06-16 02:07:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 02:29:36 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 02:29:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/879053a59c426e84f355b9ee03dc3b4e6f9ccc1f
Cr-Commit-Position: refs/heads/master@{#29034}

Powered by Google App Engine
This is Rietveld 408576698