Issue 1187033004: No need for both isLayoutBoxModelObject() and isBoxModelObject().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1187033004: No need for both isLayoutBoxModelObject() and isBoxModelObject(). (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)

Modified:
5 years, 6 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

No need for both isLayoutBoxModelObject() and isBoxModelObject(). They answer the exact same question. Deleted one and kept the most popular one (isBoxModelObject()). R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197197

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -5 lines)			Patch
M	Source/core/layout/LayoutBoxModelObject.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/layout/LayoutObject.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/layout/LayoutObject.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/paint/FrameSetPainter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

leviw_travelin_and_unemployed

Awww man, the unpopular ones always get the ax! LGTM! You're a blur of activity ...

5 years, 6 months ago (2015-06-16 19:57:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187033004/1

5 years, 6 months ago (2015-06-16 19:59:18 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-16 21:14:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197197

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages