Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: Source/core/layout/LayoutObject.h

Issue 1187033004: No need for both isLayoutBoxModelObject() and isBoxModelObject(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutBoxModelObject.h ('k') | Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 bool isTableSection() const { return isOfType(LayoutObjectTableSection); } 374 bool isTableSection() const { return isOfType(LayoutObjectTableSection); }
375 bool isTextArea() const { return isOfType(LayoutObjectTextArea); } 375 bool isTextArea() const { return isOfType(LayoutObjectTextArea); }
376 bool isTextControl() const { return isOfType(LayoutObjectTextControl); } 376 bool isTextControl() const { return isOfType(LayoutObjectTextControl); }
377 bool isTextField() const { return isOfType(LayoutObjectTextField); } 377 bool isTextField() const { return isOfType(LayoutObjectTextField); }
378 bool isVideo() const { return isOfType(LayoutObjectVideo); } 378 bool isVideo() const { return isOfType(LayoutObjectVideo); }
379 bool isWidget() const { return isOfType(LayoutObjectWidget); } 379 bool isWidget() const { return isOfType(LayoutObjectWidget); }
380 380
381 virtual bool isImage() const { return false; } 381 virtual bool isImage() const { return false; }
382 382
383 virtual bool isInlineBlockOrInlineTable() const { return false; } 383 virtual bool isInlineBlockOrInlineTable() const { return false; }
384 virtual bool isLayoutBoxModelObject() const { return false; }
385 virtual bool isLayoutBlock() const { return false; } 384 virtual bool isLayoutBlock() const { return false; }
386 virtual bool isLayoutBlockFlow() const { return false; } 385 virtual bool isLayoutBlockFlow() const { return false; }
387 virtual bool isLayoutFlowThread() const { return false; } 386 virtual bool isLayoutFlowThread() const { return false; }
388 virtual bool isLayoutInline() const { return false; } 387 virtual bool isLayoutInline() const { return false; }
389 virtual bool isLayoutPart() const { return false; } 388 virtual bool isLayoutPart() const { return false; }
390 389
391 bool isDocumentElement() const { return document().documentElement() == m_no de; } 390 bool isDocumentElement() const { return document().documentElement() == m_no de; }
392 // isBody is called from LayoutBox::styleWillChange and is thus quite hot. 391 // isBody is called from LayoutBox::styleWillChange and is thus quite hot.
393 bool isBody() const { return node() && node()->hasTagName(HTMLNames::bodyTag ); } 392 bool isBody() const { return node() && node()->hasTagName(HTMLNames::bodyTag ); }
394 bool isHR() const; 393 bool isHR() const;
(...skipping 1265 matching lines...) Expand 10 before | Expand all | Expand 10 after
1660 void showTree(const blink::LayoutObject*); 1659 void showTree(const blink::LayoutObject*);
1661 void showLineTree(const blink::LayoutObject*); 1660 void showLineTree(const blink::LayoutObject*);
1662 void showLayoutTree(const blink::LayoutObject* object1); 1661 void showLayoutTree(const blink::LayoutObject* object1);
1663 // We don't make object2 an optional parameter so that showLayoutTree 1662 // We don't make object2 an optional parameter so that showLayoutTree
1664 // can be called from gdb easily. 1663 // can be called from gdb easily.
1665 void showLayoutTree(const blink::LayoutObject* object1, const blink::LayoutObjec t* object2); 1664 void showLayoutTree(const blink::LayoutObject* object1, const blink::LayoutObjec t* object2);
1666 1665
1667 #endif 1666 #endif
1668 1667
1669 #endif // LayoutObject_h 1668 #endif // LayoutObject_h
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutBoxModelObject.h ('k') | Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698