Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1186853004: Move paint invalidation up into HTMLMediaElement::clearMediaPlayer(). (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move paint invalidation up into HTMLMediaElement::clearMediaPlayer(). To avoid (Oilpan) finalization order issues, reposition r197301's paint invalidation of media elements. Instead of triggering it as part of the destruction of the media element's media player client object, have the media element handle it on its own while initiating the destruction of the media player (and more) in clearMediaPlayer(). A simpler arrangement. R=haraken,chrishtr BUG=497614 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
5 years, 6 months ago (2015-06-18 18:41:58 UTC) #2
haraken
LGTM, but I want to have Chris take another look.
5 years, 6 months ago (2015-06-18 18:45:24 UTC) #4
chrishtr
lgtm
5 years, 6 months ago (2015-06-18 18:54:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186853004/1
5 years, 6 months ago (2015-06-18 18:55:30 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 20:44:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197395

Powered by Google App Engine
This is Rietveld 408576698