Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: Source/core/html/HTMLMediaElement.cpp

Issue 1186853004: Move paint invalidation up into HTMLMediaElement::clearMediaPlayer(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/web/WebMediaPlayerClientImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 3044 matching lines...) Expand 10 before | Expand all | Expand 10 after
3055 m_loadState = WaitingForSource; 3055 m_loadState = WaitingForSource;
3056 3056
3057 // We can't cast if we don't have a media player. 3057 // We can't cast if we don't have a media player.
3058 m_remoteRoutesAvailable = false; 3058 m_remoteRoutesAvailable = false;
3059 m_playingRemotely = false; 3059 m_playingRemotely = false;
3060 if (mediaControls()) 3060 if (mediaControls())
3061 mediaControls()->refreshCastButtonVisibility(); 3061 mediaControls()->refreshCastButtonVisibility();
3062 3062
3063 if (m_textTracks) 3063 if (m_textTracks)
3064 configureTextTrackDisplay(AssumeNoVisibleChange); 3064 configureTextTrackDisplay(AssumeNoVisibleChange);
3065
3066 if (layoutObject())
3067 layoutObject()->setShouldDoFullPaintInvalidation();
3065 } 3068 }
3066 3069
3067 void HTMLMediaElement::stop() 3070 void HTMLMediaElement::stop()
3068 { 3071 {
3069 WTF_LOG(Media, "HTMLMediaElement::stop(%p)", this); 3072 WTF_LOG(Media, "HTMLMediaElement::stop(%p)", this);
3070 3073
3071 if (m_playing && m_initialPlayWithoutUserGestures) 3074 if (m_playing && m_initialPlayWithoutUserGestures)
3072 gesturelessInitialPlayHalted(); 3075 gesturelessInitialPlayHalted();
3073 3076
3074 // Close the async event queue so that no events are enqueued by userCancell edLoad. 3077 // Close the async event queue so that no events are enqueued by userCancell edLoad.
(...skipping 597 matching lines...) Expand 10 before | Expand all | Expand 10 after
3672 3675
3673 #if ENABLE(WEB_AUDIO) 3676 #if ENABLE(WEB_AUDIO)
3674 void HTMLMediaElement::clearWeakMembers(Visitor* visitor) 3677 void HTMLMediaElement::clearWeakMembers(Visitor* visitor)
3675 { 3678 {
3676 if (!Heap::isHeapObjectAlive(m_audioSourceNode) && audioSourceProvider()) 3679 if (!Heap::isHeapObjectAlive(m_audioSourceNode) && audioSourceProvider())
3677 audioSourceProvider()->setClient(nullptr); 3680 audioSourceProvider()->setClient(nullptr);
3678 } 3681 }
3679 #endif 3682 #endif
3680 3683
3681 } 3684 }
OLDNEW
« no previous file with comments | « no previous file | Source/web/WebMediaPlayerClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698