Source/modules/device_orientation/DeviceOrientationEvent.h - Issue 1186823014: [bindings] Eliminate custom bindings for DeviceOrientationEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceOrientationEvent.h

Issue 1186823014: [bindings] Eliminate custom bindings for DeviceOrientationEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Initialize the constructor to be null Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationData.cpp ('k') | Source/modules/device_orientation/DeviceOrientationEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceOrientationEvent.h

diff --git a/Source/modules/device_orientation/DeviceOrientationEvent.h b/Source/modules/device_orientation/DeviceOrientationEvent.h

index 34e8aa67ebdcb2801d1f735e2b293d3327568d01..431fcfeb9161609f2ad1c453c6fd855b39389d06 100644

--- a/Source/modules/device_orientation/DeviceOrientationEvent.h

+++ b/Source/modules/device_orientation/DeviceOrientationEvent.h

@@ -26,6 +26,7 @@

#ifndef DeviceOrientationEvent_h

#define DeviceOrientationEvent_h

+#include "bindings/core/v8/Nullable.h"

#include "modules/EventModules.h"

#include "platform/heap/Handle.h"

@@ -46,7 +47,7 @@ public:

return adoptRefWillBeNoop(new DeviceOrientationEvent(eventType, orientation));

}

- void initDeviceOrientationEvent(const AtomicString& type, bool bubbles, bool cancelable, DeviceOrientationData*);

+ void initDeviceOrientationEvent(const AtomicString& type, bool bubbles, bool cancelable, const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, const Nullable<bool>& absolute);

DeviceOrientationData* orientation() const { return m_orientation.get(); }