Source/modules/device_orientation/DeviceOrientationEvent.cpp - Issue 1186823014: [bindings] Eliminate custom bindings for DeviceOrientationEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceOrientationEvent.cpp

Issue 1186823014: [bindings] Eliminate custom bindings for DeviceOrientationEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Initialize the constructor to be null Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationEvent.h ('k') | Source/modules/device_orientation/DeviceOrientationEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceOrientationEvent.cpp

diff --git a/Source/modules/device_orientation/DeviceOrientationEvent.cpp b/Source/modules/device_orientation/DeviceOrientationEvent.cpp

index 50edaf4eab1d42e190b5f817c485947d0d9d114e..d34d9ce2fd1f7818c6a739fb8ef03d3a817d0f10 100644

--- a/Source/modules/device_orientation/DeviceOrientationEvent.cpp

+++ b/Source/modules/device_orientation/DeviceOrientationEvent.cpp

@@ -45,13 +45,13 @@ DeviceOrientationEvent::DeviceOrientationEvent(const AtomicString& eventType, De

{

}

-void DeviceOrientationEvent::initDeviceOrientationEvent(const AtomicString& type, bool bubbles, bool cancelable, DeviceOrientationData* orientation)

+void DeviceOrientationEvent::initDeviceOrientationEvent(const AtomicString& type, bool bubbles, bool cancelable, const Nullable<double>& alpha, const Nullable<double>& beta, const Nullable<double>& gamma, const Nullable<bool>& absolute)

{

if (dispatched())

return;

initEvent(type, bubbles, cancelable);

- m_orientation = orientation;

+ m_orientation = DeviceOrientationData::create(alpha, beta, gamma, absolute);

}

double DeviceOrientationEvent::alpha(bool& isNull) const