Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1186613007: Revert of Reland "Keep track of array buffers in new space separately" (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "Keep track of array buffers in new space separately" (patchset #2 id:20001 of https://codereview.chromium.org/1177083003/) Reason for revert: Still broken Original issue's description: > Reland "Keep track of array buffers in new space separately" > > Original review https://codereview.chromium.org/1133773002/ > > BUG=v8:3996 > TBR=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3 > Cr-Commit-Position: refs/heads/master@{#28987} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Committed: https://crrev.com/a99fe1fd765d1302bec777ee36ebdb0d3216384e Cr-Commit-Position: refs/heads/master@{#29009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -184 lines) Patch
M src/api.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/heap/heap.h View 3 chunks +5 lines, -40 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +32 lines, -122 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +1 line, -6 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Reland "Keep track of array buffers in new space separately"
5 years, 6 months ago (2015-06-14 18:23:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186613007/1
5 years, 6 months ago (2015-06-14 18:23:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-14 18:23:23 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-14 18:23:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a99fe1fd765d1302bec777ee36ebdb0d3216384e
Cr-Commit-Position: refs/heads/master@{#29009}

Powered by Google App Engine
This is Rietveld 408576698