src/objects.cc - Issue 1186613007: Revert of Reland "Keep track of array buffers in new space separately"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1186613007: Revert of Reland "Keep track of array buffers in new space separately" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index ef56f08f692c7801d7e9979746ed1ea1ea1fd66c..ac3934155ddfb27ec4ce86e739203d3baa25f4c5 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -16481,8 +16481,7 @@

void* backing_store =

isolate->array_buffer_allocator()->AllocateUninitialized(

fixed_typed_array->DataSize());

- isolate->heap()->RegisterNewArrayBuffer(isolate->heap()->InNewSpace(*buffer),

- backing_store,

+ isolate->heap()->RegisterNewArrayBuffer(backing_store,

fixed_typed_array->DataSize());

buffer->set_backing_store(backing_store);

buffer->set_is_external(false);

« no previous file with comments | « src/heap/objects-visiting-inl.h ('k') | src/runtime/runtime-typedarray.cc » ('j') | no next file with comments »