Support Timer with 0 millisecond delay in dart2js running in the command line.

Support Timer with 0 millisecond delay in dart2js running in the command line.
Committed: https://code.google.com/p/dart/source/detail?r=16968

[kasperl, 2013-01-11 11:58:08]

LGTM as a starting point. Great to see all these tests that now pass again. I
would still argue that we shouldn't use a timer for delaying the execution of
futures -- we should have a simpler event queuing mechanism.

Would it be easy to factor out the event loop part of the isolate library so
that you don't have to bring in everything just because someone uses a little
bit of Timer/Future stuff?

https://codereview.chromium.org/11866003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/enqueue.dart (right):

https://codereview.chromium.org/11866003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/enqueue.dart:417: // isolate library.
or if we use timers from the dart:async library.

https://codereview.chromium.org/11866003/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/11866003/diff/1/tests/lib/lib.status#newcode10
tests/lib/lib.status:10: async/future_test: Fail # Timer interface not
supported; dartbug.com/7728.
I guess some of these tests now fail for a different reason?

https://codereview.chromium.org/11866003/diff/1/tests/lib/lib.status#newcode35
tests/lib/lib.status:35: async/future_test: Fail # TODO(ngeoaffray): Please
triage these failure.
Maybe fix your username?

[ngeoffray, 2013-01-11 12:20:18]

Just compiling the event queue would require quite some refactoring on our
isolate implementation. Since Timers is in the flux and our isolate library may
require a rewrite, I prefer being heavyweight for now and drag in the whole
isolate library.

https://codereview.chromium.org/11866003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/enqueue.dart (right):

https://codereview.chromium.org/11866003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/enqueue.dart:417: // isolate library.
On 2013/01/11 11:58:08, kasperl wrote:
> or if we use timers from the dart:async library.

Done.

https://codereview.chromium.org/11866003/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/11866003/diff/1/tests/lib/lib.status#newcode10
tests/lib/lib.status:10: async/future_test: Fail # Timer interface not
supported; dartbug.com/7728.
On 2013/01/11 11:58:08, kasperl wrote:
> I guess some of these tests now fail for a different reason?

Good catch. They actually continue to fail because we don't support Timers with
> 0 wait. I have updated issue 7728 accordingly.

https://codereview.chromium.org/11866003/diff/1/tests/lib/lib.status#newcode35
tests/lib/lib.status:35: async/future_test: Fail # TODO(ngeoaffray): Please
triage these failure.
On 2013/01/11 11:58:08, kasperl wrote:
> Maybe fix your username?

Done.

[floitsch, 2013-01-11 12:35:52]

LGTM.

[ahe, 2013-01-11 18:44:06]

AWESOME! THANK YOU.

This means that tests/compiler/dart2js_extra/mirror_test.dart is passing on V8,
and it also greatly simplifies my work on lazy loading.

Cheers,
Peter