Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1186573004: [turbofan] Remove dead code from JSGenericLowering. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove dead code from JSGenericLowering. R=bmeurer@chromium.org Committed: https://crrev.com/65b6cef8ebd06c4ddd8fd954536a15d3c806ea2d Cr-Commit-Position: refs/heads/master@{#29036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
Dead code is being dead. Feel free to CQ.
5 years, 6 months ago (2015-06-15 15:09:30 UTC) #1
Benedikt Meurer
Truly amazing! LGTM.
5 years, 6 months ago (2015-06-16 04:00:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186573004/1
5 years, 6 months ago (2015-06-16 04:00:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 04:02:01 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 04:02:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65b6cef8ebd06c4ddd8fd954536a15d3c806ea2d
Cr-Commit-Position: refs/heads/master@{#29036}

Powered by Google App Engine
This is Rietveld 408576698